[ORC-301] `extractFileTail` should open a file in `try` statement - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.4.1
Fix Version/s: 1.4.4, 1.5.0
Component/s: Java
Labels:
None

Description

To prevent opened file leakage, we need to move the file open position.

--- a/java/core/src/java/org/apache/orc/impl/ReaderImpl.java
       long maxFileLength) throws IOException {
-    FSDataInputStream file = fs.open(path);
+    FSDataInputStream file = null;
     ByteBuffer buffer;
     OrcProto.PostScript ps;
     OrcProto.FileTail.Builder fileTailBuilder = OrcProto.FileTail.newBuilder();
     long modificationTime;
     try {
+      file = fs.open(path);