Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-266

[C++] A few issues with cmake scripts and non-vendored third party libraries

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • C++
    • None

    Description

      Currently there are a few issues with the cmake build system:

      • Running `make install` (or `make package`) when using any non-vendored third party library results in copying all files not matching `".so|.dylib"` from the `*_HOME/lib` directory into the `lib/` directory. This is because third party libraries are being installed via a filter instead of specific file paths. This is definitely a bug.
      • There is no easy way to specify third party library locations when using orc as an `ExternalProject` in another cmake project. This is easily fixed by separating the defining of `*_HOME` variables from their use, which allows e.g. `-DSNAPPY_HOME=...` to work.
      • There is no way to avoid building the tests
      • There is no way to avoid building the tools
      • The LICENSE and NOTICE get installed into the root directory, which is not where they should go. Since the header files all contain the license header, and other apache projects don't install the license, the lines installing these files should be removable.

      Attachments

        Issue Links

          Activity

            People

              jim.crist Jim Crist
              jim.crist Jim Crist
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: