[ORC-168] Documentation Writer Example: batch.size++ has a wrong possition

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Not A Problem
• Component/s: documentation, Java
• Assignee: Unassigned
• Reporter: Philipp Blum
• Created: 25/Mar/17 21:51
• Updated: 13/Apr/17 22:44
• Resolved: 13/Apr/17 22:44

Description

There's one little mistake in the Java Core Example. The for loops starts with a batch.size++:

for(int r=0; r < 10000; ++r) {
int row = batch.size++;
x.vector[row] = r;
y.vector[row] = r * 3;
// If the batch is full, write it out and start over.
if (batch.size == batch.getMaxSize())

{ writer.addRowBatch(batch); batch.reset(); }
}

If you start with a batch.size++ the first index will be 1, so the first entry in the orc file will be empty.
Correct is:

for(int r=0; r < 10000; ++r) {
int row = batch.size;
x.vector[row] = r;
y.vector[row] = r * 3;
// If the batch is full, write it out and start over.
if (batch.size == batch.getMaxSize()) { writer.addRowBatch(batch); batch.reset(); }

batch.size++;
}

Already tested it in scala.

Issue Links

• links to: GitHub Pull Request #104