[ORC-157] Test failed due to timezone DST

• Type: Test
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.3.3
• Fix Version/s: 1.3.4, 1.4.0
• Component/s: tools
• Assignee: Owen O'Malley
• Reporter: Andrey Morskoy
• Created: 14/Mar/17 08:50
• Updated: 08/May/17 17:22
• Resolved: 17/Mar/17 16:52

Description

To reproduce:
% mkdir build
% cd build
% cmake .. -DBUILD_JAVA=OFF
% make package
% make test-out

Output is:
[ FAILED ] TestMatchParam/FileParam.Contents/20, where GetParam() = orc_split_elim.orc

1 FAILED TEST

Sample line is:
/storage/progs/src/orc-rel-release-1.3.3/tools/test/TestMatch.cc:149: Failure
Value of: line
Actual: "

{\"userid\": 100, \"string1\": \"zebra\", \"subtype\": 8, \"decimal1\": 0.000000, \"ts\": \"1969-12-31 17:04:10.0\"}

"
Expected: expectedLine
Which is: "

{\"userid\": 100, \"string1\": \"zebra\", \"subtype\": 8, \"decimal1\": 0.000000, \"ts\": \"1969-12-31 16:04:10.0\"}

"
wrong output at row 24999

so ts: 1 hour difference

I am at Ukraine (GMT+2 + DST). I could suppose, that as our DST change is at the end of march (while US changes in the beginning of March AFAIK) - something wrong with timestamp with timezone interpretation in this test - and probably after Ukraine moves to DST - effect will disappear.
So there is 2 weeks windows when this test could FAIL

Issue Links

• links to: GitHub Pull Request #100