[ORC-1475] [C++] ConvertColumnReader.TestConvertNumericToStringVariant fails when compiled with unsigned char

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 2.0.0, 1.9.2
• Component/s: C++
• Assignee: Yuanping Wu
• Reporter: Gang Wu
• Created: 13/Aug/23 01:43
• Updated: 08/Mar/24 17:32
• Resolved: 15/Aug/23 02:58

Description

[----------] 6 tests from ConvertColumnReader
[ RUN ] ConvertColumnReader.betweenNumericWithoutOverflows
[ OK ] ConvertColumnReader.betweenNumericWithoutOverflows (7 ms)
[ RUN ] ConvertColumnReader.betweenNumricOverflows
[ OK ] ConvertColumnReader.betweenNumricOverflows (0 ms)
[ RUN ] ConvertColumnReader.booleanToString
[ OK ] ConvertColumnReader.booleanToString (0 ms)
[ RUN ] ConvertColumnReader.TestConvertNumericToStringVariant
/root/orc/c++/test/TestConvertColumnReader.cc:339: Failure
Expected equality of these values:
expected[1]
Which is: "254"
std::string(readC1.data[i], static_cast<size_t>(readC1.length[i]))
Which is: "-2"
2
/root/orc/c++/test/TestConvertColumnReader.cc:339: Failure
Expected equality of these values:
expected[1]
Which is: "252"
std::string(readC1.data[i], static_cast<size_t>(readC1.length[i]))
Which is: "-4"
4

Issue Links

• links to: GitHub Pull Request #1579
• links to: GitHub Pull Request #1582