[ORC-1473] Zero-copy zeroCopyReadRanges and releaseBuffer bugs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: Java, Reader
• Assignee: xiebin
• Reporter: xiebin
• Created: 08/Aug/23 08:54
• Updated: 08/Mar/24 17:33
• Resolved: 21/Sep/23 18:02

Description

I found two bugs

1. org.apache.orc.impl.RecordReaderUtils#zeroCopyReadRanges

   ByteBuffer copy = currentBuffer.duplicate();
   copy.position((int) (current.getOffset() - currentOffset)); 

   if currentBuffer position is not 0, copy.position() will set a uncorrect position.
   I think we should use slice() replace duplicate().

1. org.apache.orc.impl.ZeroCopyShims.ZeroCopyAdapter#releaseBuffer
   The parameter `buffer` is not the original buffer from hdfs reading. It is the slice or duplicate of the original buffer.
   This bug is reported at ORC-700.

 

 

Issue Links

• duplicates: ORC-700 StripePlanner buffer management issues with zero copy
• links to: GitHub Pull Request #1574
• links to: GitHub Pull Request #1574