Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-1440

Check for protobuf config based module

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.0.0
    • build
    • None

    Description

      What:
      At the moment, the build on Windows fails with: failure.win.txt

      Why:
      The recent version of `libprotobuf` generates code that depends on `abseil`. It can lead to issues for downstream consumers of the library. Example: https://github.com/protocolbuffers/protobuf/issues/11920

      Potential Resolution:

      The `orc::protobuf` interface target depends on our hand-rolled find module for `libprotobuf`. The recent versions of `libprotobuf` provide their own CMake configs. We can check for the existence of the config and use the hand-rolled version as a fallback.

      Attachments

        1. failure.win.txt
          4 kB
          Nehal Jagdish Wani

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nehaljwani Nehal Jagdish Wani
            nehaljwani Nehal Jagdish Wani
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment