[ORC-1147] Use `isNaN` instead of `isFinite` to determine the contain NaN values

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.3, 1.6.13
• Fix Version/s: 1.7.4, 1.6.14
• Component/s: Java
• Assignee: Yiqun Zhang
• Reporter: Yiqun Zhang
• Created: 05/Apr/22 03:43
• Updated: 15/Apr/22 23:26
• Resolved: 06/Apr/22 04:59

Description

      if (!Double.isFinite(dstas.getSum())) {
        LOG.debug("Not using predication pushdown on {} because stats contain NaN values",
                predicate.getColumnName());
        return dstas.hasNull() ? TruthValue.YES_NO_NULL : TruthValue.YES_NO;
      }
}

The isFinite function does not determine whether there is a NaN write or not, and there is a possibility of a sum overflow; we should use `isNaN` instead to determine this

Issue Links

• links to: GitHub Pull Request #1080
• links to: GitHub Pull Request #1082