Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-1146

Float category missing check if the statistic sum is a finite value

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.7.3
    • 1.7.4, 1.6.14
    • Java
    • None

    Description

      https://github.com/apache/orc/blob/70c504cbd759342476d2fb2c9cc75a5025cb7c11/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java#L696-L703

      } else if (category == TypeDescription.Category.DOUBLE) { 
         DoubleColumnStatistics dstas = (DoubleColumnStatistics) cs; 
         if (!Double.isFinite(dstas.getSum())) { 
           LOG.debug("Not using predication pushdown on {} because stats contain NaN values", 
                   predicate.getColumnName()); 
           return dstas.hasNull() ? TruthValue.YES_NO_NULL : TruthValue.YES_NO; 
         } 
       } 
      

      Currently only the Double category is checked. the Float category is also only pushed down if the statistics sum to a finite value.

      Attachments

        Activity

          People

            Guiyankuang Yiqun Zhang
            Guiyankuang Yiqun Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: