[ORC-103] Make ORC Reader resilient to 0 length files

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.1, 1.3.0
• Component/s: Reader
• Assignee: Prasanth Jayachandran
• Reporter: Prasanth Jayachandran
• Created: 30/Sep/16 20:29
• Updated: 06/Oct/16 15:30
• Resolved: 02/Oct/16 15:39

Description

Orc reader will throw IndexOutOfBounds if used directly. Following is the exception

Caused by: java.lang.IndexOutOfBoundsException
	at java.nio.Buffer.checkIndex(Buffer.java:540)
	at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:139)
	at org.apache.orc.impl.ReaderImpl.extractFileTail(ReaderImpl.java:515)
	at org.apache.orc.impl.ReaderImpl.<init>(ReaderImpl.java:368)
	at org.apache.orc.OrcFile.createReader(OrcFile.java:222)
	at org.apache.orc.TestReader.testReadZeroLengthFile(TestReader.java:57)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
	... 22 more

Input format usually avoids such files but not generating splits but if someone uses the Reader directly on invalid files it should be resilient too. OrcOutputFormat will not create a 0 length so this shouldn't be a problem for files written by Orc itself.

Issue Links

• links to: GitHub Pull Request #61