[ORC-1008] Overflow detection code is incorrect in IntegerColumnStatisticsImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0, 1.7.0
• Fix Version/s: 1.7.1, 1.6.12
• Component/s: C++, Java
• Assignee: Yiqun Zhang
• Reporter: Yiqun Zhang
• Created: 27/Sep/21 06:59
• Updated: 02/Feb/22 23:52
• Resolved: 30/Sep/21 04:24

Description

void IntegerColumnStatisticsImpl::update(int64_t value, int repetitions) { 
   _stats.updateMinMax(value); 
  
   if (_stats.hasSum()) { 
     bool wasPositive = _stats.getSum() >= 0; 
     _stats.setSum(value * repetitions + _stats.getSum()); 
     if ((value >= 0) == wasPositive) { 
       _stats.setHasSum((_stats.getSum() >= 0) == wasPositive); 
     } 
   } 
 } 

A counter-example can easily be given
Assume sum=1, update(std::numeric_limits<int64_t>::max(), 3);
value * repetitions + _stats.getSum() is overflowed, but is still a positive number : 9223372036854775806

Issue Links

• causes: ORC-1042 Ignore unused-function C++ compile warning on CentOS 7
• links to: GitHub Pull Request #917
• links to: GitHub Pull Request #950
• links to: GitHub Pull Request #951