Github user nahguam commented on the pull request:
Hi, what's the best place for comments?
The diff is too big to comment directly so I'll list a couple here:
1. OrcRecordReader.next L94 - seems to be a dead-end?
2. How is one to use OrcStruct as an end user? getFieldValue and setFieldValue are package private. Previously you'd access via the StructObjectInspector, but we seem to have no ObjectInspectors or StructFields.
OrcInputFormat<OrcStruct> inputFormat = new OrcInputFormat<>();
InputSplit splits = inputFormat.getSplits(conf, 1);
RecordReader<NullWritable, OrcStruct> recordReader = inputFormat.getRecordReader(splits, conf, null);
NullWritable key = recordReader.createKey();
OrcStruct value = recordReader.createValue();
while (recordReader.next(key, value))
// How do I interrogate value for it's fields' values?
3. Perhaps for another ticket, but it would be nice to have a mechanism to access a struct's fields by name as well as by index.
4. Is there any particular reason that the value generic type is V extends Writable instead of OrcStruct?