[OPENNLP-985] A condition that is always true.

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.1.1
• Component/s: wsd
• Assignee: Bruno P. Kinoshita
• Reporter: JC
• Created: 11/Feb/17 18:18
• Updated: 13/Feb/23 14:15
• Resolved: 13/Feb/23 14:15

Description

I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)

Path: opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java

85   public boolean contains(String wordTag) {
86 
87     for (Sentence isentence : this.getSsentences()) {
88       for (Word iword : isentence.getIwords()) {
89         if (iword.equals(iword))
90           return true;
91       }
92     }
93 
94     return false;
95   }

Line 89 is always true. This might be a trivial issue but wanted to report just in case. Thanks!

Issue Links

• links to: GitHub Pull Request #1