[OPENNLP-887] Replace the Cache class with a LinkedHashMap

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Assignee: Suneel Marthi
• Reporter: Jörn Kottmann
• Created: 10/Nov/16 00:21
• Updated: 19/Dec/16 22:30
• Resolved: 19/Dec/16 22:30

Description

The existing cache implementation could be replaced with java.util.LinkedHashMap. This change would replace our custom implementation with an implementation which will be maintained for us.

To have the same behaviour as our implementation LinkedHashMap must be subclasses. The LinkedHashMap.removeEldestEntry must be overwritten and return true if size limit is reached.

This could be something like this:

import java.util.LinkedHashMap;
import java.util.Iterator;
import java.util.Map;

public class Cache<K, V> extends LinkedHashMap<K,V> {
private final int capacity;

public Cache(int capacity)

{ this.capacity = capacity; }

@Override
protected boolean removeEldestEntry(Map.Entry<K,V> eldest)

{ return this.size() > this.capacity; }

}

Issue Links

• links to: GitHub Pull Request #9