[OPENNLP-717] NameFinder trainer creates model always with default feature generator

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.6.0
• Component/s: Name Finder
• Assignee: Rodrigo Agerri
• Reporter: Rodrigo Agerri
• Created: 06/Oct/14 11:18
• Updated: 08/Oct/14 16:23
• Resolved: 08/Oct/14 16:23

Description

While adding new features to name finder (e.g., OPENNLP-714) it was noticed that the NameFinder trainer performance degraded after adding more features than those contained in the default generator.

It turned out that at the moment of creating the TokenNameFinderModel, the feature generator parameter was not the one used for the training, but a default one (null). As a result, the init() method in TokenNameFinderModel always created the model with the default feature generator.

Solution: add a getter in the TokenNameFinderFactory class to have access to the featureGenerator created for each implementation of the factory, and then use that getter as a parameter when creating the models after training. It has been implemented and tested and it works.

If you find this solution ok, I will push the commit.