[OPENNLP-1471] Ensure Dictionary#asStringSet() implements hashCode() and equals() correctly

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0, 2.1.1
• Fix Version/s: 2.2.0
• Assignee: Martin Wiesner
• Reporter: Martin Wiesner
• Created: 19/Feb/23 12:45
• Updated: 22/Apr/23 17:39
• Resolved: 25/Feb/23 22:09

Description

The tests  (a)  DictionaryAsSetCaseInsensitiveTest and 
(b) DictionaryAsSetCaseSensitiveTest have an open TODO that points to a bug in Dictionary#asStringSet()
 

// TODO: should it be equal??
Assertions.assertNotSame(setA.hashCode(), setB.hashCode());

To cure this, the implementation of Dictionary#asStringSet() needs override hashCode and equals properly.

After fixing the implementation, the following assertion must hold:

Assertions.assertEquals(setA, setB);

Assertions.assertEquals(setA.hashCode(), setB.hashCode());

where setA and setB are obtained via Dictionary#asStringSet().