[OPENNLP-1076] SentenceSample should validate if spans are inside the text

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.8.1
• Component/s: Sentence Detector
• Assignee: Jörn Kottmann
• Reporter: Jörn Kottmann
• Created: 24/May/17 10:02
• Updated: 24/May/17 10:25
• Resolved: 24/May/17 10:25

Description

The SentenceSample should validate if the provided Spans to mark sentence boundaries are within bounds of the provided document text. If the spans are outside of the document text an IllegalArgumentException should be thrown to make the code fail fast. Otherwise code which processes the SentenceSamples will fail later and make it slightly harder to find the actual bug.

Issue Links

• links to: GitHub Pull Request #216