Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0 Apache Release
    • Component/s: None
    • Labels:
      None

      Description

      When a moderator tries to provide somebody an exclusive audio, he should confirm this operation. The confirmation dialog should contains "don't show again" checkbox.

      1. Mute dialog.jpg
        198 kB
        Vasiliy Degtyarev
      2. fix2.patch
        2 kB
        Artyom Horuzhenko
      3. exclusive_audio_confirmation.patch
        18 kB
        Artyom Horuzhenko
      4. exclusive_audio_confirmation_fix.patch
        0.5 kB
        Artyom Horuzhenko

        Activity

        Hide
        Vasiliy Degtyarev added a comment -

        Tested for 1447126 revisoin. It seems that fix is ok.

        Show
        Vasiliy Degtyarev added a comment - Tested for 1447126 revisoin. It seems that fix is ok.
        Hide
        Maxim Solodovnik added a comment -

        commited

        Show
        Maxim Solodovnik added a comment - commited
        Hide
        Artyom Horuzhenko added a comment -

        It stopped working for some unknown reason

        Show
        Artyom Horuzhenko added a comment - It stopped working for some unknown reason
        Hide
        Maxim Solodovnik added a comment -

        Committed revision 1443848.

        Show
        Maxim Solodovnik added a comment - Committed revision 1443848.
        Hide
        Maxim Solodovnik added a comment -

        Reopened, according to Vasiliy's comment

        Show
        Maxim Solodovnik added a comment - Reopened, according to Vasiliy's comment
        Hide
        Vasiliy Degtyarev added a comment -

        I have tested this fix and found that the header of confirmation dialog is not correct and oversteps the bounds of window. Please see attachment.

        Show
        Vasiliy Degtyarev added a comment - I have tested this fix and found that the header of confirmation dialog is not correct and oversteps the bounds of window. Please see attachment.
        Hide
        Maxim Solodovnik added a comment -

        At revision: 1443314

        Few comments:
        1) if (answer == true) { is equivalent to if (answer) {
        2) please use tabs instead of spaces

        Show
        Maxim Solodovnik added a comment - At revision: 1443314 Few comments: 1) if (answer == true) { is equivalent to if (answer) { 2) please use tabs instead of spaces

          People

          • Assignee:
            Maxim Solodovnik
            Reporter:
            Artyom Horuzhenko
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development