[OPENEJB-1250] StatelessInstanceManager divide by null causes ArithmeticException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.3
• Component/s: container system
• Labels: container
• Environment: NA
• Assignee: Andy Gumbrecht
• Reporter: Andy Gumbrecht
• Created: 31/Mar/10 18:29
• Updated: 19/May/10 20:24
• Resolved: 19/May/10 20:24

Description

org.apache.openejb.core.stateless.StatelessInstanceManager line 399

long offset = ((long) (maxAge / min * i * maxAgeOffset)) % maxAge;

Quite often gets 0 for maxAge (for example):

ArithmeticException - 0 / 2 * 0 * -1.0

So I'd like to suggest a fix:

long offset = (maxAge > 0 ? ((long) (maxAge / min * i * maxAgeOffset)) % maxAge : 0L);