OpenEJB
  1. OpenEJB
  2. OPENEJB-1014

Make jndi implementation more pluggable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 4.0
    • Component/s: container system
    • Labels:
      None

      Description

      When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
      (discussion on dev list)

      1. OPENEJB-1014.diff
        20 kB
        David Jencks
      2. OPENEJB-1014-2.diff
        61 kB
        David Jencks
      3. OPENEJB-1014-3.diff
        47 kB
        David Jencks
      4. OPENEJB-1014-4.diff
        38 kB
        David Jencks
      5. XbeanJndiFactory.java
        4 kB
        David Jencks
      6. OPENEJB-1014-5.diff
        36 kB
        David Jencks
      7. OPENEJB-1014-6.diff
        10 kB
        David Jencks

        Issue Links

          Activity

          Hide
          Jean-Louis MONTEIRO added a comment -

          No issue until now. Thanks a lot David. Feel free to re open if needed

          Show
          Jean-Louis MONTEIRO added a comment - No issue until now. Thanks a lot David. Feel free to re open if needed
          Hide
          David Jencks added a comment -

          Apply patch 6 in rev 948243. I'm not aware of more problems but want to review again.

          Show
          David Jencks added a comment - Apply patch 6 in rev 948243. I'm not aware of more problems but want to review again.
          Hide
          David Jencks added a comment -

          Geronimo has improved it's java: handling by using the aries jndi code and now the remaining java: prefixes are causing problems. Attached patch removes the ones I've located. I think this does not break the openejb build.

          Not applying now in case it conflicts with other ongoing work.

          Show
          David Jencks added a comment - Geronimo has improved it's java: handling by using the aries jndi code and now the remaining java: prefixes are causing problems. Attached patch removes the ones I've located. I think this does not break the openejb build. Not applying now in case it conflicts with other ongoing work.
          Hide
          David Jencks added a comment -

          Expect a Context that supports creating missing subcontexts in bind.
          Does not include david's proposal for the JndiRequestHandler fix.

          Show
          David Jencks added a comment - Expect a Context that supports creating missing subcontexts in bind. Does not include david's proposal for the JndiRequestHandler fix.
          Hide
          David Jencks added a comment -

          Geronmo openejb-xbean gbean. I'm not sure how adaptable to openejb this might be, for geronimo it needs to be a gbean to federate with the global context.

          Show
          David Jencks added a comment - Geronmo openejb-xbean gbean. I'm not sure how adaptable to openejb this might be, for geronimo it needs to be a gbean to federate with the global context.
          Hide
          David Jencks added a comment -

          Applied most of the java: removal bits of the patch: improved PersistenceBuilder patch

          Show
          David Jencks added a comment - Applied most of the java: removal bits of the patch: improved PersistenceBuilder patch
          Hide
          David Jencks added a comment -

          Add a convenience method to ContainerSystem to simplify getting the root jndi context.

          Show
          David Jencks added a comment - Add a convenience method to ContainerSystem to simplify getting the root jndi context.
          Hide
          David Jencks added a comment -

          More sophisticated patch that...

          • introduces a factory to create jndi context and do bind operations.
          • removes all the java: prefixes I can find from the global jndi tree access.
          • tries to not rely on special case stripping behavior of ivm context, e.g. looking up "openejb/Deployment" to get a context and then looking up "openejb/Deployment/foo" and expecting the same as looking up "foo" in this context.
          Show
          David Jencks added a comment - More sophisticated patch that... introduces a factory to create jndi context and do bind operations. removes all the java: prefixes I can find from the global jndi tree access. tries to not rely on special case stripping behavior of ivm context, e.g. looking up "openejb/Deployment" to get a context and then looking up "openejb/Deployment/foo" and expecting the same as looking up "foo" in this context.
          Hide
          David Jencks added a comment -

          First draft of changes that make openejb work in geronimo using the geronimo global jndi. For discussion, not commit as-is.

          Show
          David Jencks added a comment - First draft of changes that make openejb work in geronimo using the geronimo global jndi. For discussion, not commit as-is.

            People

            • Assignee:
              David Jencks
              Reporter:
              David Jencks
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development