[OOZIE-957] TestStatusTransitService and TestCoordKillXCommand are failing randomly; replace Thread.sleep()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.0
• Component/s: tests
• Assignee: Robert Kanter
• Reporter: Alejandro Abdelnur
• Created: 15/Aug/12 22:16
• Updated: 03/Dec/12 22:37
• Resolved: 22/Aug/12 01:15

Description

Failed tests:   testCoordStatusTransitServicePaused(org.apache.oozie.service.TestStatusTransitService): expected:<RUNNINGWITHERROR> but was:<PAUSEDWITHERROR>
  testBundleStatusTransitServiceSucceeded2(org.apache.oozie.service.TestStatusTransitService): expected:<SUCCEEDED> but was:<RUNNING>
  testCoordStatusTransitServiceSuspendedWithError(org.apache.oozie.service.TestStatusTransitService): expected:<SUSPENDEDWITHERROR> but was:<SUSPENDED>

Tests in error: 
  testCoordKillSuccess1(org.apache.oozie.command.coord.TestCoordKillXCommand): The transaction has been rolled back.  See the nested exceptions for details on the errors that occurred.

We should replace all calls to Thread.sleep() in tests with a call to waitFor() so that oozie.test.waitfor.ratio will scale them (unless there is a specific reason not to).