[OOZIE-580] use xml element to handle string escape when configure evaluator

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: pre-Apache
• Assignee: Angelo K. Huang
• Reporter: Angelo K. Huang
• Created: 13/Oct/11 23:41
• Updated: 02/Mar/12 22:47
• Resolved: 03/Jan/12 17:29

Description

Instead of using string value to do escape, xml element is able to do it and also avoid escaping legit character at XML element, such as <![CDATA[]]>.

public static void configureEvaluator(ELEvaluator evaluator, WorkflowJobBean workflow, WorkflowActionBean action) {
evaluator.setVariable(WORKFLOW, workflow);
evaluator.setVariable(ACTION, action);
for (Map.Entry<String, String> entry : workflow.getWorkflowInstance().getConf()) {
if (ParamChecker.isValidIdentifier(entry.getKey()))

{ String value = entry.getValue().trim(); // escape the characters for xml value = XmlUtils.escapeCharsForXML(value); evaluator.setVariable(entry.getKey().trim(), value); }

}
try

{ evaluator.setVariable(ACTION_PROTO_CONF, new XConfiguration(new StringReader(workflow.getProtoActionConf()))); }

catch (IOException ex)

{ throw new RuntimeException("It should not happen", ex); }

}