[OOZIE-3589] Avoid calling copyActionData method multiple times in ReRunXCommand

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.3.0
• Component/s: core
• Assignee: Junfan Zhang
• Reporter: Junfan Zhang
• Created: 21/Feb/20 16:21
• Updated: 02/Mar/20 12:44
• Resolved: 02/Mar/20 12:44

Description

Code is here.

I don't think you should use the copyActionData method in a for loop. Just call it externally.

Fixed like:

for (int i = 0; i < actions.size(); i++) {
            // Skipping to delete the sub workflow when rerun failed node option has been provided. As same
            // action will be used to rerun the job.
            if (!nodesToSkip.contains(actions.get(i).getName()) &&
                    !(conf.getBoolean(OozieClient.RERUN_FAIL_NODES, false) &&
                    SubWorkflowActionExecutor.ACTION_TYPE.equals(actions.get(i).getType()))) {
                deleteList.add(actions.get(i));
                LOG.info("Deleting Action[{0}] for re-run", actions.get(i).getId());
            }
        }
copyActionData(newWfInstance, oldWfInstance);