Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-3121

bump all maven plugins to latest versions

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.3.0
    • 5.0.0
    • None
    • None

    Description

      bump all maven plugins to latest

      Attachments

        1. OOZIE-3121.patch
          5 kB
          Artem Ervits
        2. OOZIE-3121-02.patch
          5 kB
          Artem Ervits

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -

            Testing JIRA OOZIE-3121

            Cleaning local git workspace

            ----------------------------

            +1 PATCH_APPLIES
            +1 CLEAN
            -1 RAW_PATCH_ANALYSIS
            . +1 the patch does not introduce any @author tags
            . +1 the patch does not introduce any tabs
            . +1 the patch does not introduce any trailing spaces
            . +1 the patch does not introduce any line longer than 132
            . -1 the patch does not add/modify any testcase
            +1 RAT
            . +1 the patch does not seem to introduce new RAT warnings
            +1 JAVADOC
            . +1 the patch does not seem to introduce new Javadoc warnings
            . WARNING: the current HEAD has 77 Javadoc warning(s)
            +1 COMPILE
            . +1 HEAD compiles
            . +1 patch compiles
            . +1 the patch does not seem to introduce new javac warnings
            -1 There are [125] new bugs found below threshold in total that must be fixed.
            . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At EmailActionExecutor.java:[line 267]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At EmailActionExecutor.java:[line 162]: At EmailActionExecutor.java:[line 160]
            . At EmailActionExecutor.java:[line 176]: At EmailActionExecutor.java:[line 171]
            . At SshActionExecutor.java:[line 134]: This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection
            . At SshActionExecutor.java:[line 131]: At SshActionExecutor.java:[line 130]
            . -1 There are [1] new bugs found below threshold in [server] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html
            . The most important FindBugs errors are:
            . At JspHandlerProvider.java:[line 43]: java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At JspHandlerProvider.java:[line 43]
            . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieCLI.java:[line 841]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 839]
            . At OozieCLI.java:[line 839]: At OozieCLI.java:[line 849]
            . At OozieCLI.java:[line 876]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 871]
            . +1 There are no new bugs found in [docs].
            . -1 There are [2] new bugs found below threshold in [examples] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html
            . The most important FindBugs errors are:
            . At LocalOozieExample.java:[line 47]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java:[line 35]
            . At LocalOozieExample.java:[line 35]: At LocalOozieExample.java:[line 72]
            . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html
            . The most important FindBugs errors are:
            . At HiveMain.java:[line 317]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 226]: At HiveMain.java:[line 207]
            . At HiveMain.java:[line 210]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 207]
            . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html
            . The most important FindBugs errors are:
            . At PigMain.java:[line 258]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At PigMain.java:[line 141]: At PigMain.java:[line 131]
            . At PigMain.java:[line 245]: At PigMain.java:[line 199]
            . At PigMain.java:[line 137]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java:[line 131]
            . +1 There are no new bugs found in [sharelib/distcp].
            . +1 There are no new bugs found in [sharelib/streaming].
            . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html
            . The most important FindBugs errors are:
            . At SparkMain.java:[line 128]: java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java:[line 128]
            . At SparkMain.java:[line 161]: At SparkMain.java:[line 168]
            . At SparkMain.java:[line 167]
            . +1 There are no new bugs found in [sharelib/hcatalog].
            . +1 There are no new bugs found in [sharelib/sqoop].
            . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html
            . The most important FindBugs errors are:
            . At Hive2Main.java:[line 279]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At Hive2Main.java:[line 165]: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 149]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 118]: At Hive2Main.java:[line 267]
            . -1 There are [8] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At LauncherMain.java:[line 471]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 461]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 140]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java:[line 176]
            . At LauncherMain.java:[line 176]: At LauncherMain.java:[line 144]
            . -1 There are [29] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieDBCLI.java:[line 548]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            . At OozieDBCLI.java:[line 126]: At OozieDBCLI.java:[line 122]
            . At OozieDBCLI.java:[line 229]: At OozieDBCLI.java:[line 133]
            . At OozieDBCLI.java:[line 703]: At OozieDBCLI.java:[line 249]
            . At OozieDBCLI.java:[line 577]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            +1 BACKWARDS_COMPATIBILITY
            . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
            . +1 the patch does not modify JPA files
            -1 TESTS
            . Tests run: 2054
            . Tests failed: 8
            . Tests errors: 2

            . The patch failed the following testcases:

            . testMain(org.apache.oozie.action.hadoop.TestHiveMain)
            . testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
            . testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
            . testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
            . testImportTablesOverflowBatchSize(org.apache.oozie.tools.TestDBLoadDump)
            . testImportInvalidDataLeavesTablesEmpty(org.apache.oozie.tools.TestDBLoadDump)
            . testImportToNonEmptyTablesCausesPrematureExit(org.apache.oozie.tools.TestDBLoadDump)
            . testImportedDBIsExportedCorrectly(org.apache.oozie.tools.TestDBLoadDump)

            . Tests failing with errors:
            . testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
            . testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)

            +1 DISTRO
            . +1 distro tarball builds with the patch

            ----------------------------
            -1 Overall result, please check the reported -1(s)

            . There is at least one warning, please check

            The full output of the test-patch run is available at

            . https://builds.apache.org/job/PreCommit-OOZIE-Build/209/

            hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-3121 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings . WARNING : the current HEAD has 77 Javadoc warning(s) +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 There are [125] new bugs found below threshold in total that must be fixed. . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important FindBugs errors are: . At EmailActionExecutor.java: [line 267] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At EmailActionExecutor.java: [line 162] : At EmailActionExecutor.java: [line 160] . At EmailActionExecutor.java: [line 176] : At EmailActionExecutor.java: [line 171] . At SshActionExecutor.java: [line 134] : This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection . At SshActionExecutor.java: [line 131] : At SshActionExecutor.java: [line 130] . -1 There are [1] new bugs found below threshold in [server] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html . The most important FindBugs errors are: . At JspHandlerProvider.java: [line 43] : java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At JspHandlerProvider.java: [line 43] . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieCLI.java: [line 841] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 839] . At OozieCLI.java: [line 839] : At OozieCLI.java: [line 849] . At OozieCLI.java: [line 876] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 871] . +1 There are no new bugs found in [docs] . . -1 There are [2] new bugs found below threshold in [examples] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html . The most important FindBugs errors are: . At LocalOozieExample.java: [line 47] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java: [line 35] . At LocalOozieExample.java: [line 35] : At LocalOozieExample.java: [line 72] . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html . The most important FindBugs errors are: . At HiveMain.java: [line 317] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 226] : At HiveMain.java: [line 207] . At HiveMain.java: [line 210] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 207] . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html . The most important FindBugs errors are: . At PigMain.java: [line 258] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At PigMain.java: [line 141] : At PigMain.java: [line 131] . At PigMain.java: [line 245] : At PigMain.java: [line 199] . At PigMain.java: [line 137] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java: [line 131] . +1 There are no new bugs found in [sharelib/distcp] . . +1 There are no new bugs found in [sharelib/streaming] . . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html . The most important FindBugs errors are: . At SparkMain.java: [line 128] : java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java: [line 128] . At SparkMain.java: [line 161] : At SparkMain.java: [line 168] . At SparkMain.java: [line 167] . +1 There are no new bugs found in [sharelib/hcatalog] . . +1 There are no new bugs found in [sharelib/sqoop] . . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html . The most important FindBugs errors are: . At Hive2Main.java: [line 279] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At Hive2Main.java: [line 165] : At Hive2Main.java: [line 146] . At Hive2Main.java: [line 149] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java: [line 146] . At Hive2Main.java: [line 118] : At Hive2Main.java: [line 267] . -1 There are [8] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The top [5] most important FindBugs errors are: . At LauncherMain.java: [line 471] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 461] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 140] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java: [line 176] . At LauncherMain.java: [line 176] : At LauncherMain.java: [line 144] . -1 There are [29] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieDBCLI.java: [line 548] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . At OozieDBCLI.java: [line 126] : At OozieDBCLI.java: [line 122] . At OozieDBCLI.java: [line 229] : At OozieDBCLI.java: [line 133] . At OozieDBCLI.java: [line 703] : At OozieDBCLI.java: [line 249] . At OozieDBCLI.java: [line 577] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 2054 . Tests failed: 8 . Tests errors: 2 . The patch failed the following testcases: . testMain(org.apache.oozie.action.hadoop.TestHiveMain) . testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain) . testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain) . testPigScript(org.apache.oozie.action.hadoop.TestPigMain) . testImportTablesOverflowBatchSize(org.apache.oozie.tools.TestDBLoadDump) . testImportInvalidDataLeavesTablesEmpty(org.apache.oozie.tools.TestDBLoadDump) . testImportToNonEmptyTablesCausesPrematureExit(org.apache.oozie.tools.TestDBLoadDump) . testImportedDBIsExportedCorrectly(org.apache.oozie.tools.TestDBLoadDump) . Tests failing with errors: . testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration) . testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) . There is at least one warning, please check The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/209/
            dbist13 Artem Ervits added a comment -

            all tests pass locally, will address findbug issues in a separate jira.

            dbist13 Artem Ervits added a comment - all tests pass locally, will address findbug issues in a separate jira.
            gezapeti GĂ©zapeti added a comment -

            I'm retargeting this to 5.0.0 so it's not blocking the 5.0-b1 release.
            I'll look into the test failures because this looks way too many.

            gezapeti GĂ©zapeti added a comment - I'm retargeting this to 5.0.0 so it's not blocking the 5.0-b1 release. I'll look into the test failures because this looks way too many.
            hadoopqa Hadoop QA added a comment -

            PreCommit-OOZIE-Build started

            hadoopqa Hadoop QA added a comment - PreCommit-OOZIE-Build started
            hadoopqa Hadoop QA added a comment -

            PreCommit-OOZIE-Build started

            hadoopqa Hadoop QA added a comment - PreCommit-OOZIE-Build started
            hadoopqa Hadoop QA added a comment -

            Testing JIRA OOZIE-3121

            Cleaning local git workspace

            ----------------------------

            -1 Patch failed to apply to head of branch

            ----------------------------

            hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-3121 Cleaning local git workspace ---------------------------- -1 Patch failed to apply to head of branch ----------------------------
            hadoopqa Hadoop QA added a comment -

            Testing JIRA OOZIE-3121

            Cleaning local git workspace

            ----------------------------

            -1 Patch failed to apply to head of branch

            ----------------------------

            hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-3121 Cleaning local git workspace ---------------------------- -1 Patch failed to apply to head of branch ----------------------------
            gezapeti GĂ©zapeti added a comment -

            dbist13. can you rebase the patch please?

            gezapeti GĂ©zapeti added a comment - dbist13 . can you rebase the patch please?
            dbist13 Artem Ervits added a comment -

            gezapeti rebased the patch and added newer versions to a couple of artifacts.

            dbist13 Artem Ervits added a comment - gezapeti rebased the patch and added newer versions to a couple of artifacts.
            hadoopqa Hadoop QA added a comment -

            PreCommit-OOZIE-Build started

            hadoopqa Hadoop QA added a comment - PreCommit-OOZIE-Build started
            gezapeti GĂ©zapeti added a comment -

            Thanks for the quick update!
            +1 (pending jenkins) for the patch!

            gezapeti GĂ©zapeti added a comment - Thanks for the quick update! +1 (pending jenkins) for the patch!
            hadoopqa Hadoop QA added a comment -

            Testing JIRA OOZIE-3121

            Cleaning local git workspace

            ----------------------------

            +1 PATCH_APPLIES
            +1 CLEAN
            -1 RAW_PATCH_ANALYSIS
            . +1 the patch does not introduce any @author tags
            . +1 the patch does not introduce any tabs
            . +1 the patch does not introduce any trailing spaces
            . +1 the patch does not introduce any line longer than 132
            . -1 the patch does not add/modify any testcase
            +1 RAT
            . +1 the patch does not seem to introduce new RAT warnings
            +1 JAVADOC
            . +1 the patch does not seem to introduce new Javadoc warnings
            . WARNING: the current HEAD has 100 Javadoc warning(s)
            +1 COMPILE
            . +1 HEAD compiles
            . +1 patch compiles
            . +1 the patch does not seem to introduce new javac warnings
            -1 There are [126] new bugs found below threshold in total that must be fixed.
            . +1 There are no new bugs found in [docs].
            . +1 There are no new bugs found in [sharelib/distcp].
            . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html
            . The most important FindBugs errors are:
            . At HiveMain.java:[line 317]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 226]: At HiveMain.java:[line 207]
            . At HiveMain.java:[line 210]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 207]
            . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html
            . The most important FindBugs errors are:
            . At SparkMain.java:[line 128]: java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java:[line 128]
            . At SparkMain.java:[line 161]: At SparkMain.java:[line 168]
            . At SparkMain.java:[line 167]
            . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html
            . The most important FindBugs errors are:
            . At Hive2Main.java:[line 279]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At Hive2Main.java:[line 165]: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 149]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 118]: At Hive2Main.java:[line 267]
            . +1 There are no new bugs found in [sharelib/hcatalog].
            . +1 There are no new bugs found in [sharelib/streaming].
            . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html
            . The most important FindBugs errors are:
            . At PigMain.java:[line 258]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At PigMain.java:[line 141]: At PigMain.java:[line 131]
            . At PigMain.java:[line 245]: At PigMain.java:[line 199]
            . At PigMain.java:[line 137]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java:[line 131]
            . +1 There are no new bugs found in [sharelib/sqoop].
            . -1 There are [9] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At LauncherMain.java:[line 473]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 463]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 140]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java:[line 176]
            . At LauncherMain.java:[line 176]: At LauncherMain.java:[line 144]
            . -1 There are [2] new bugs found below threshold in [examples] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html
            . The most important FindBugs errors are:
            . At LocalOozieExample.java:[line 47]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java:[line 35]
            . At LocalOozieExample.java:[line 35]: At LocalOozieExample.java:[line 72]
            . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieCLI.java:[line 841]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 839]
            . At OozieCLI.java:[line 839]: At OozieCLI.java:[line 849]
            . At OozieCLI.java:[line 876]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 871]
            . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At EmailActionExecutor.java:[line 268]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At EmailActionExecutor.java:[line 163]: At EmailActionExecutor.java:[line 161]
            . At EmailActionExecutor.java:[line 177]: At EmailActionExecutor.java:[line 172]
            . At SshActionExecutor.java:[line 135]: This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection
            . At SshActionExecutor.java:[line 132]: At SshActionExecutor.java:[line 131]
            . -1 There are [29] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieDBCLI.java:[line 548]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            . At OozieDBCLI.java:[line 126]: At OozieDBCLI.java:[line 122]
            . At OozieDBCLI.java:[line 229]: At OozieDBCLI.java:[line 133]
            . At OozieDBCLI.java:[line 703]: At OozieDBCLI.java:[line 249]
            . At OozieDBCLI.java:[line 577]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            . -1 There are [1] new bugs found below threshold in [server] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html
            . The most important FindBugs errors are:
            . At JspHandlerProvider.java:[line 43]: java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At JspHandlerProvider.java:[line 43]
            +1 BACKWARDS_COMPATIBILITY
            . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
            . +1 the patch does not modify JPA files
            -1 TESTS
            . Tests run: 2088
            . Tests failed: 4
            . Tests errors: 1

            . The patch failed the following testcases:

            testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
            testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
            testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener)
            testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)

            . Tests failing with errors:
            testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)

            . Tests failed at first run:
            TestJavaActionExecutor#testCredentialsSkip
            . For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
            +1 DISTRO
            . +1 distro tarball builds with the patch

            ----------------------------
            -1 Overall result, please check the reported -1(s)

            . There is at least one warning, please check

            The full output of the test-patch run is available at

            . https://builds.apache.org/job/PreCommit-OOZIE-Build/368/

            hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-3121 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings . WARNING : the current HEAD has 100 Javadoc warning(s) +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 There are [126] new bugs found below threshold in total that must be fixed. . +1 There are no new bugs found in [docs] . . +1 There are no new bugs found in [sharelib/distcp] . . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html . The most important FindBugs errors are: . At HiveMain.java: [line 317] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 226] : At HiveMain.java: [line 207] . At HiveMain.java: [line 210] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 207] . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html . The most important FindBugs errors are: . At SparkMain.java: [line 128] : java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java: [line 128] . At SparkMain.java: [line 161] : At SparkMain.java: [line 168] . At SparkMain.java: [line 167] . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html . The most important FindBugs errors are: . At Hive2Main.java: [line 279] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At Hive2Main.java: [line 165] : At Hive2Main.java: [line 146] . At Hive2Main.java: [line 149] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java: [line 146] . At Hive2Main.java: [line 118] : At Hive2Main.java: [line 267] . +1 There are no new bugs found in [sharelib/hcatalog] . . +1 There are no new bugs found in [sharelib/streaming] . . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html . The most important FindBugs errors are: . At PigMain.java: [line 258] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At PigMain.java: [line 141] : At PigMain.java: [line 131] . At PigMain.java: [line 245] : At PigMain.java: [line 199] . At PigMain.java: [line 137] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java: [line 131] . +1 There are no new bugs found in [sharelib/sqoop] . . -1 There are [9] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The top [5] most important FindBugs errors are: . At LauncherMain.java: [line 473] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 463] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 140] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java: [line 176] . At LauncherMain.java: [line 176] : At LauncherMain.java: [line 144] . -1 There are [2] new bugs found below threshold in [examples] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html . The most important FindBugs errors are: . At LocalOozieExample.java: [line 47] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java: [line 35] . At LocalOozieExample.java: [line 35] : At LocalOozieExample.java: [line 72] . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieCLI.java: [line 841] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 839] . At OozieCLI.java: [line 839] : At OozieCLI.java: [line 849] . At OozieCLI.java: [line 876] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 871] . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important FindBugs errors are: . At EmailActionExecutor.java: [line 268] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At EmailActionExecutor.java: [line 163] : At EmailActionExecutor.java: [line 161] . At EmailActionExecutor.java: [line 177] : At EmailActionExecutor.java: [line 172] . At SshActionExecutor.java: [line 135] : This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection . At SshActionExecutor.java: [line 132] : At SshActionExecutor.java: [line 131] . -1 There are [29] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieDBCLI.java: [line 548] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . At OozieDBCLI.java: [line 126] : At OozieDBCLI.java: [line 122] . At OozieDBCLI.java: [line 229] : At OozieDBCLI.java: [line 133] . At OozieDBCLI.java: [line 703] : At OozieDBCLI.java: [line 249] . At OozieDBCLI.java: [line 577] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . -1 There are [1] new bugs found below threshold in [server] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html . The most important FindBugs errors are: . At JspHandlerProvider.java: [line 43] : java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At JspHandlerProvider.java: [line 43] +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 2088 . Tests failed: 4 . Tests errors: 1 . The patch failed the following testcases: testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService) testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener) testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache) . Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) . Tests failed at first run: TestJavaActionExecutor#testCredentialsSkip . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) . There is at least one warning, please check The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/368/
            hadoopqa Hadoop QA added a comment -

            PreCommit-OOZIE-Build started

            hadoopqa Hadoop QA added a comment - PreCommit-OOZIE-Build started
            hadoopqa Hadoop QA added a comment -

            Testing JIRA OOZIE-3121

            Cleaning local git workspace

            ----------------------------

            +1 PATCH_APPLIES
            +1 CLEAN
            -1 RAW_PATCH_ANALYSIS
            . +1 the patch does not introduce any @author tags
            . +1 the patch does not introduce any tabs
            . +1 the patch does not introduce any trailing spaces
            . +1 the patch does not introduce any line longer than 132
            . -1 the patch does not add/modify any testcase
            +1 RAT
            . +1 the patch does not seem to introduce new RAT warnings
            +1 JAVADOC
            . +1 the patch does not seem to introduce new Javadoc warnings
            . WARNING: the current HEAD has 100 Javadoc warning(s)
            +1 COMPILE
            . +1 HEAD compiles
            . +1 patch compiles
            . +1 the patch does not seem to introduce new javac warnings
            -1 There are [128] new bugs found below threshold in total that must be fixed.
            . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At EmailActionExecutor.java:[line 268]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At EmailActionExecutor.java:[line 163]: At EmailActionExecutor.java:[line 161]
            . At EmailActionExecutor.java:[line 177]: At EmailActionExecutor.java:[line 172]
            . At SshActionExecutor.java:[line 135]: This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection
            . At SshActionExecutor.java:[line 132]: At SshActionExecutor.java:[line 131]
            . -1 There are [31] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieDBCLI.java:[line 561]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            . At OozieDBCLI.java:[line 127]: At OozieDBCLI.java:[line 123]
            . At OozieDBCLI.java:[line 232]: At OozieDBCLI.java:[line 134]
            . At OozieDBCLI.java:[line 716]: At OozieDBCLI.java:[line 257]
            . At OozieDBCLI.java:[line 590]: java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input
            . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html
            . The most important FindBugs errors are:
            . At Hive2Main.java:[line 279]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At Hive2Main.java:[line 165]: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 149]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java:[line 146]
            . At Hive2Main.java:[line 118]: At Hive2Main.java:[line 267]
            . +1 There are no new bugs found in [sharelib/distcp].
            . +1 There are no new bugs found in [sharelib/hcatalog].
            . +1 There are no new bugs found in [sharelib/streaming].
            . +1 There are no new bugs found in [sharelib/sqoop].
            . -1 There are [9] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At LauncherMain.java:[line 473]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 463]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At LauncherMain.java:[line 140]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java:[line 176]
            . At LauncherMain.java:[line 176]: At LauncherMain.java:[line 144]
            . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html
            . The most important FindBugs errors are:
            . At PigMain.java:[line 258]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At PigMain.java:[line 141]: At PigMain.java:[line 131]
            . At PigMain.java:[line 245]: At PigMain.java:[line 199]
            . At PigMain.java:[line 137]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java:[line 131]
            . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html
            . The most important FindBugs errors are:
            . At HiveMain.java:[line 317]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 226]: At HiveMain.java:[line 207]
            . At HiveMain.java:[line 210]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At HiveMain.java:[line 207]
            . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html
            . The most important FindBugs errors are:
            . At SparkMain.java:[line 128]: java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java:[line 128]
            . At SparkMain.java:[line 161]: At SparkMain.java:[line 168]
            . At SparkMain.java:[line 167]
            . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones.
            . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html
            . The top [5] most important FindBugs errors are:
            . At OozieCLI.java:[line 841]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 839]
            . At OozieCLI.java:[line 839]: At OozieCLI.java:[line 849]
            . At OozieCLI.java:[line 876]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java:[line 871]
            . -1 There are [2] new bugs found below threshold in [examples] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html
            . The most important FindBugs errors are:
            . At LocalOozieExample.java:[line 47]: java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input
            . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java:[line 35]
            . At LocalOozieExample.java:[line 35]: At LocalOozieExample.java:[line 72]
            . +1 There are no new bugs found in [docs].
            . -1 There are [1] new bugs found below threshold in [server] that must be fixed.
            . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html
            . The most important FindBugs errors are:
            . At JspHandlerProvider.java:[line 43]: java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input
            . At JspHandlerProvider.java:[line 43]
            +1 BACKWARDS_COMPATIBILITY
            . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
            . +1 the patch does not modify JPA files
            -1 TESTS
            . Tests run: 2089
            . Tests failed: 1
            . Tests errors: 0

            . The patch failed the following testcases:

            testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

            . Tests failing with errors:

            . Tests failed at first run:
            TestJavaActionExecutor#testCredentialsSkip
            TestCoordActionsKillXCommand#testActionKillCommandDate
            . For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
            +1 DISTRO
            . +1 distro tarball builds with the patch

            ----------------------------
            -1 Overall result, please check the reported -1(s)

            . There is at least one warning, please check

            The full output of the test-patch run is available at

            . https://builds.apache.org/job/PreCommit-OOZIE-Build/378/

            hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-3121 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings . WARNING : the current HEAD has 100 Javadoc warning(s) +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 There are [128] new bugs found below threshold in total that must be fixed. . -1 There are [67] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important FindBugs errors are: . At EmailActionExecutor.java: [line 268] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At EmailActionExecutor.java: [line 163] : At EmailActionExecutor.java: [line 161] . At EmailActionExecutor.java: [line 177] : At EmailActionExecutor.java: [line 172] . At SshActionExecutor.java: [line 135] : This usage of java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection . At SshActionExecutor.java: [line 132] : At SshActionExecutor.java: [line 131] . -1 There are [31] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieDBCLI.java: [line 561] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . At OozieDBCLI.java: [line 127] : At OozieDBCLI.java: [line 123] . At OozieDBCLI.java: [line 232] : At OozieDBCLI.java: [line 134] . At OozieDBCLI.java: [line 716] : At OozieDBCLI.java: [line 257] . At OozieDBCLI.java: [line 590] : java/io/FileWriter.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . -1 There are [3] new bugs found below threshold in [sharelib/hive2] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive2/findbugs-new.html . The most important FindBugs errors are: . At Hive2Main.java: [line 279] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At Hive2Main.java: [line 165] : At Hive2Main.java: [line 146] . At Hive2Main.java: [line 149] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileOutputStream.<init>(Ljava/lang/String;)V writes to a file whose location might be specified by user input: At Hive2Main.java: [line 146] . At Hive2Main.java: [line 118] : At Hive2Main.java: [line 267] . +1 There are no new bugs found in [sharelib/distcp] . . +1 There are no new bugs found in [sharelib/hcatalog] . . +1 There are no new bugs found in [sharelib/streaming] . . +1 There are no new bugs found in [sharelib/sqoop] . . -1 There are [9] new bugs found below threshold in [sharelib/oozie] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The top [5] most important FindBugs errors are: . At LauncherMain.java: [line 473] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 463] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java: [line 140] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileReader.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LauncherMain.java: [line 176] . At LauncherMain.java: [line 176] : At LauncherMain.java: [line 144] . -1 There are [3] new bugs found below threshold in [sharelib/pig] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/pig/findbugs-new.html . The most important FindBugs errors are: . At PigMain.java: [line 258] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At PigMain.java: [line 141] : At PigMain.java: [line 131] . At PigMain.java: [line 245] : At PigMain.java: [line 199] . At PigMain.java: [line 137] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At PigMain.java: [line 131] . -1 There are [2] new bugs found below threshold in [sharelib/hive] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/hive/findbugs-new.html . The most important FindBugs errors are: . At HiveMain.java: [line 317] : java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 226] : At HiveMain.java: [line 207] . At HiveMain.java: [line 210] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At HiveMain.java: [line 207] . -1 There are [2] new bugs found below threshold in [sharelib/spark] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/spark/findbugs-new.html . The most important FindBugs errors are: . At SparkMain.java: [line 128] : java/io/File.<init>(Ljava/io/File;Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At SparkMain.java: [line 128] . At SparkMain.java: [line 161] : At SparkMain.java: [line 168] . At SparkMain.java: [line 167] . -1 There are [8] new bugs found below threshold in [client] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieCLI.java: [line 841] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 839] . At OozieCLI.java: [line 839] : At OozieCLI.java: [line 849] . At OozieCLI.java: [line 876] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At OozieCLI.java: [line 871] . -1 There are [2] new bugs found below threshold in [examples] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html . The most important FindBugs errors are: . At LocalOozieExample.java: [line 47] : java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At LocalOozieExample.java: [line 35] . At LocalOozieExample.java: [line 35] : At LocalOozieExample.java: [line 72] . +1 There are no new bugs found in [docs] . . -1 There are [1] new bugs found below threshold in [server] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html . The most important FindBugs errors are: . At JspHandlerProvider.java: [line 43] : java/io/File.<init>(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At JspHandlerProvider.java: [line 43] +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 2089 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor) . Tests failing with errors: . Tests failed at first run: TestJavaActionExecutor#testCredentialsSkip TestCoordActionsKillXCommand#testActionKillCommandDate . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) . There is at least one warning, please check The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/378/
            gezapeti GĂ©zapeti added a comment -

            +1, test passes locally. The warnings are related to the new versions of the plugins, we'll burn them down eventually

            gezapeti GĂ©zapeti added a comment - +1, test passes locally. The warnings are related to the new versions of the plugins, we'll burn them down eventually
            gezapeti GĂ©zapeti added a comment -

            committed to master!

            gezapeti GĂ©zapeti added a comment - committed to master!
            andras.piros Andras Piros added a comment -

            Closing issue; Oozie 5.0.0 is released.

            andras.piros Andras Piros added a comment - Closing issue; Oozie 5.0.0 is released.

            People

              dbist13 Artem Ervits
              dbist13 Artem Ervits
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: