Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2474

<job-xml> is not being applied to the launcher job

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Properties included via <job-xml> don't get applied to the Oozie Launcher MR job, only to the action child jobs. This includes oozie.launcher.* properties. The oozie.launcher.* properties should end up in the launcher job as oozie.launcher.foo and foo, just like if you had put them in <configuration>.

        Activity

        Hide
        rkanter Robert Kanter added a comment -

        Closing issue; Oozie 4.3.0 is released.

        Show
        rkanter Robert Kanter added a comment - Closing issue; Oozie 4.3.0 is released.
        Hide
        rkanter Robert Kanter added a comment -

        Thanks for the review Rohini (and Satish). Committed to master!

        Show
        rkanter Robert Kanter added a comment - Thanks for the review Rohini (and Satish). Committed to master!
        Hide
        rohini Rohini Palaniswamy added a comment -

        +1

        Show
        rohini Rohini Palaniswamy added a comment - +1
        Hide
        satishsaley Satish Subhashrao Saley added a comment -

        +1.
        Users need to be notified, because their oozie.launcher properties, which were present idly in job.xml, will be getting into effect when this fix gets shipped.

        Show
        satishsaley Satish Subhashrao Saley added a comment - +1. Users need to be notified, because their oozie.launcher properties, which were present idly in job.xml, will be getting into effect when this fix gets shipped.
        Hide
        rkanter Robert Kanter added a comment -

        Test failures unrelated

        Show
        rkanter Robert Kanter added a comment - Test failures unrelated
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2474

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 1 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1763
        . Tests failed: 2
        . Tests errors: 0

        . The patch failed the following testcases:

        . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)
        . testSamplers(org.apache.oozie.util.TestMetricsInstrumentation)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/2769/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2474 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1763 . Tests failed: 2 . Tests errors: 0 . The patch failed the following testcases: . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration) . testSamplers(org.apache.oozie.util.TestMetricsInstrumentation) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2769/
        Hide
        rkanter Robert Kanter added a comment -

        The patch does a little refactoring to have the injectLauncherProperties method also parse the <job-xml> and keep the oozie.launcher properties. I also added a unit test, but most of the test changes are due to defining <job-xml> but not actually using or creating the file, which became a problem now that it's actually read by the JavaActionExecutor.

        Show
        rkanter Robert Kanter added a comment - The patch does a little refactoring to have the injectLauncherProperties method also parse the <job-xml> and keep the oozie.launcher properties. I also added a unit test, but most of the test changes are due to defining <job-xml> but not actually using or creating the file, which became a problem now that it's actually read by the JavaActionExecutor .

          People

          • Assignee:
            rkanter Robert Kanter
            Reporter:
            rkanter Robert Kanter
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development