Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-1881 Docs fixes
  3. OOZIE-2370

Docs for Coordinator Action Status Notification has wrong property name

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0
    • Component/s: docs
    • Labels:
      None

      Description

      The docs for the Coordinator Action Status Notification (here) list the config property as oozie.coord.workflow.notification.url. That property is incorrect; it's actually oozie.coord.action.notification.url.

      1. OOZIE-2370.001.patch
        1.0 kB
        Eva Andreasson

        Issue Links

          Activity

          Hide
          rkanter Robert Kanter added a comment -

          Closing issue; Oozie 4.3.0 is released.

          Show
          rkanter Robert Kanter added a comment - Closing issue; Oozie 4.3.0 is released.
          Hide
          rkanter Robert Kanter added a comment -

          Thanks Eva. Congrats on your first JIRA

          Committed to trunk!

          Show
          rkanter Robert Kanter added a comment - Thanks Eva. Congrats on your first JIRA Committed to trunk!
          Hide
          rkanter Robert Kanter added a comment -

          +1

          Show
          rkanter Robert Kanter added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2370

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1707
          . Tests failed: 4
          . Tests errors: 0

          . The patch failed the following testcases:

          . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)
          . testPurgeXCommandFailed(org.apache.oozie.command.TestPurgeXCommand)
          . testPurgeWFWithSubWF1(org.apache.oozie.command.TestPurgeXCommand)
          . testSamplers(org.apache.oozie.util.TestMetricsInstrumentation)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2714/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2370 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1707 . Tests failed: 4 . Tests errors: 0 . The patch failed the following testcases: . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration) . testPurgeXCommandFailed(org.apache.oozie.command.TestPurgeXCommand) . testPurgeWFWithSubWF1(org.apache.oozie.command.TestPurgeXCommand) . testSamplers(org.apache.oozie.util.TestMetricsInstrumentation) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2714/
          Hide
          eeeva Eva Andreasson added a comment -

          Let me know if there is anything else I need to provide. The issue was resolved by fixing the typo, i.e. switching "workload" to "action" in the referenced property name in the document.

          Show
          eeeva Eva Andreasson added a comment - Let me know if there is anything else I need to provide. The issue was resolved by fixing the typo, i.e. switching "workload" to "action" in the referenced property name in the document.
          Hide
          eeeva Eva Andreasson added a comment -

          Uploading patch file

          Show
          eeeva Eva Andreasson added a comment - Uploading patch file
          Hide
          rkanter Robert Kanter added a comment -

          That looks like the right change, but you need to put it into a file. For example:

          git diff --no-prefix > OOZIE-2370.001.patch
          

          Then you upload it here by clicking "More" and "Attach Files".
          Once that's done, click the "Submit Patch" button.

          Show
          rkanter Robert Kanter added a comment - That looks like the right change, but you need to put it into a file. For example: git diff --no-prefix > OOZIE-2370.001.patch Then you upload it here by clicking "More" and "Attach Files". Once that's done, click the "Submit Patch" button.
          Hide
          eeeva Eva Andreasson added a comment -

          Tried to follow all instructions on the Oozie wiki to learn the process of helping with contributions. Please guide further, as needed, but please find below the git diff results in my local environment:

          diff --git docs/src/site/twiki/CoordinatorFunctionalSpec.twiki docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
          index 4ada5cf..a27b5af 100644
          — docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
          +++ docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
          @@ -3571,7 +3571,7 @@ See also [WorkflowFunctionalSpec#WorkflowNotifications[Workflow Notifications]

          ---+++ 15.1 Coordinator Action Status Notification

          -If the =oozie.coord.workflow.notification.url= property is present in the coordinator job properties when submitting the job,
          +If the =oozie.coord.action.notification.url= property is present in the coordinator job properties when submitting the job,
          Oozie will make a notification to the provided URL when any of the coordinator's actions changes its status.
          =oozie.coord.action.notification.proxy= property can be used to configure either a http or socks proxy.
          The format is proxyHostname:port or proxyType@proxyHostname:port. If proxy type is not specified, it defaults to http.

          Show
          eeeva Eva Andreasson added a comment - Tried to follow all instructions on the Oozie wiki to learn the process of helping with contributions. Please guide further, as needed, but please find below the git diff results in my local environment: diff --git docs/src/site/twiki/CoordinatorFunctionalSpec.twiki docs/src/site/twiki/CoordinatorFunctionalSpec.twiki index 4ada5cf..a27b5af 100644 — docs/src/site/twiki/CoordinatorFunctionalSpec.twiki +++ docs/src/site/twiki/CoordinatorFunctionalSpec.twiki @@ -3571,7 +3571,7 @@ See also [ WorkflowFunctionalSpec#WorkflowNotifications [Workflow Notifications] ---+++ 15.1 Coordinator Action Status Notification -If the =oozie.coord.workflow.notification.url= property is present in the coordinator job properties when submitting the job, +If the =oozie.coord.action.notification.url= property is present in the coordinator job properties when submitting the job, Oozie will make a notification to the provided URL when any of the coordinator's actions changes its status. =oozie.coord.action.notification.proxy= property can be used to configure either a http or socks proxy. The format is proxyHostname:port or proxyType@proxyHostname:port. If proxy type is not specified, it defaults to http.

            People

            • Assignee:
              eeeva Eva Andreasson
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development