Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2365

oozie fail to start when smtp password not set

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      when oozie.email.smtp.password not set, oozie fails to start.
      it should be able to handle null or default-value.

      Caused by: java.lang.NullPointerException
      at java.lang.String.<init>(String.java:166)
      at org.apache.oozie.service.ConfigurationService.getPassword(ConfigurationService.java:556)
      at org.apache.oozie.service.ConfigurationService.getPassword(ConfigurationService.java:571)
      at org.apache.oozie.sla.listener.SLAEmailEventListener.init(SLAEmailEventListener.java:110)
      at org.apache.oozie.service.EventHandlerService.addEventListener(EventHandlerService.java:142)
      at org.apache.oozie.service.EventHandlerService.initEventListeners(EventHandlerService.java:120)
      at org.apache.oozie.service.EventHandlerService.init(EventHandlerService.java:83)

      1. OOZIE-2365-1.patch
        10 kB
        Rohini Palaniswamy

        Issue Links

          Activity

          Hide
          Cazen Cazen Lee added a comment -

          Good Day Michelle!

          May I have a look? I think there will be NPE when getPassword with new String(null)..

          And need some more details. Does it occured when start-up oozie? or when running e-mail action?

          Thanks.

          Show
          Cazen Cazen Lee added a comment - Good Day Michelle! May I have a look? I think there will be NPE when getPassword with new String(null).. And need some more details. Does it occured when start-up oozie? or when running e-mail action? Thanks.
          Hide
          Cazen Cazen Lee added a comment -

          It seems that "char[] pass" in ConfigurationService.getPassword could be null.
          new String(null) cause NPE, so needeed to NPE handling.

          This patch will help But I'm not sure this patch better than edit hadoop.conf.Configuration

          If I was wrong, please notify me

          Thank you

          Show
          Cazen Cazen Lee added a comment - It seems that "char[] pass" in ConfigurationService.getPassword could be null. new String(null) cause NPE, so needeed to NPE handling. This patch will help But I'm not sure this patch better than edit hadoop.conf.Configuration If I was wrong, please notify me Thank you
          Hide
          rohini Rohini Palaniswamy added a comment -

          Cazen Lee,
          Sorry for hijacking this. I already had a patch for the issue Michelle Chiang reported when she encountered the issue. Just missed uploading it on Friday. Added a defaultValue option instead of making "" as the default.

          Show
          rohini Rohini Palaniswamy added a comment - Cazen Lee , Sorry for hijacking this. I already had a patch for the issue Michelle Chiang reported when she encountered the issue. Just missed uploading it on Friday. Added a defaultValue option instead of making "" as the default.
          Hide
          Cazen Cazen Lee added a comment -

          Hi Rohini Palaniswamy
          Nope, it's just simple work
          But some comment before start will help to reduce duplicated work
          Anyway, Have a good day

          Show
          Cazen Cazen Lee added a comment - Hi Rohini Palaniswamy Nope, it's just simple work But some comment before start will help to reduce duplicated work Anyway, Have a good day
          Hide
          rohini Rohini Palaniswamy added a comment -

          Sorry about that. Friday was a very busy day and I did not get the time to post the patch. Also I did not expect anyone else to pick it up.

          Show
          rohini Rohini Palaniswamy added a comment - Sorry about that. Friday was a very busy day and I did not get the time to post the patch. Also I did not expect anyone else to pick it up.
          Hide
          puru Purshotam Shah added a comment -

          +1

          Show
          puru Purshotam Shah added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2365

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1694
          . Tests failed: 2
          . Tests errors: 0

          . The patch failed the following testcases:

          . testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI)
          . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2550/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2365 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1694 . Tests failed: 2 . Tests errors: 0 . The patch failed the following testcases: . testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI) . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2550/
          Hide
          rohini Rohini Palaniswamy added a comment -

          Test failures unrelated. Committed to trunk. Thanks for the review Puru.

          Show
          rohini Rohini Palaniswamy added a comment - Test failures unrelated. Committed to trunk. Thanks for the review Puru.
          Hide
          rkanter Robert Kanter added a comment -

          Closing issue; Oozie 4.3.0 is released.

          Show
          rkanter Robert Kanter added a comment - Closing issue; Oozie 4.3.0 is released.

            People

            • Assignee:
              rohini Rohini Palaniswamy
              Reporter:
              mchiang_4work@yahoo.com Michelle Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development