Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2159

'oozie validate' command should be moved server-side

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      The oozie validate command runs an XML validator against a workflow, coordinator, or bundle XML file to check that it's valid with any of the XSD schema files we have.

      Currently, this is implemented in the Oozie CLI (OozieCLI.validateCommand(...), which has some downsides:

      1. It's only available to OozieCLI users; anyone using the REST API can't use it
      2. It's currently hardcoded to the specific XSD files we ship with Oozie
        1. Whenever we add a new schema, we have to also manually update this, which is easy to forget
        2. Users can't validate custom schemas that the Oozie server would accept

      We should move this to the Oozie server, perhaps at a new "validate" endpoint. It should be able to accept a local file path (the current behavior) and perhaps also an HDFS file while we're at it. For the local XML file, it can just be uploaded as part of the REST call.

      Also, the description for the command needs to be updated to mention that it also handles coordinators and bundles.

      1. OOZIE-2159.6.patch
        63 kB
        Azrael Seoeun
      2. OOZIE-2159.5.patch
        62 kB
        Azrael Seoeun
      3. OOZIE-2159.4.patch
        61 kB
        Azrael Seoeun
      4. OOZIE-2159.3.patch
        61 kB
        Azrael Seoeun
      5. OOZIE-2159.2.patch
        46 kB
        Azrael Seoeun
      6. OOZIE-2159.1.patch
        39 kB
        Azrael Seoeun

        Issue Links

          Activity

          Hide
          rkanter Robert Kanter added a comment -

          One thing to keep in mind is backwards compatibility. We'd presumably add this to the v2 API. Older clients talking to a newer server should be fine because they have the current behavior in the client; but newer clients talking to an older server won't work.

          Show
          rkanter Robert Kanter added a comment - One thing to keep in mind is backwards compatibility. We'd presumably add this to the v2 API. Older clients talking to a newer server should be fine because they have the current behavior in the client; but newer clients talking to an older server won't work.
          Hide
          seoeun25 Azrael Seoeun added a comment -

          I linked to RB. Please review it.

          Show
          seoeun25 Azrael Seoeun added a comment - I linked to RB. Please review it.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . +1 the patch does adds/modifies 1 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          . WARNING: the current HEAD has 1 Javadoc warning(s)
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 1 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1655
          . Tests failed: 6
          . Tests errors: 0

          . The patch failed the following testcases:

          . testCoordLogStreaming(org.apache.oozie.TestCoordinatorEngineStreamLog)
          . testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService)
          . testValidateWorkFlowCommand(org.apache.oozie.client.TestOozieCLI)
          . testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI)
          . testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand)
          . testValid(org.apache.oozie.cli.TestValidation)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          . There is at least one warning, please check

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2308/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings . WARNING : the current HEAD has 1 Javadoc warning(s) -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 1 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1655 . Tests failed: 6 . Tests errors: 0 . The patch failed the following testcases: . testCoordLogStreaming(org.apache.oozie.TestCoordinatorEngineStreamLog) . testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService) . testValidateWorkFlowCommand(org.apache.oozie.client.TestOozieCLI) . testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI) . testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand) . testValid(org.apache.oozie.cli.TestValidation) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) . There is at least one warning, please check The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2308/
          Hide
          seoeun25 Azrael Seoeun added a comment -

          Fix test failures ( org.apache.oozie.client.TestOozieCLI.testValidateWorkFlowCommand) and remove org.apache.oozie.cli.TestValidation as we move to server-side.
          Other test failures are unrelated.

          Show
          seoeun25 Azrael Seoeun added a comment - Fix test failures ( org.apache.oozie.client.TestOozieCLI.testValidateWorkFlowCommand) and remove org.apache.oozie.cli.TestValidation as we move to server-side. Other test failures are unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 1 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1654
          . Tests failed: 1
          . Tests errors: 0

          . The patch failed the following testcases:

          . testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2313/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 1 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1654 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2313/
          Hide
          seoeun25 Azrael Seoeun added a comment -

          -1 the patch seems to introduce 1 new javac warning(s)
          : The validation method on client-side is deprecated but still there for backward compatibility.

          The test failure is unrelated.

          Show
          seoeun25 Azrael Seoeun added a comment - -1 the patch seems to introduce 1 new javac warning(s) : The validation method on client-side is deprecated but still there for backward compatibility. The test failure is unrelated.
          Hide
          seoeun25 Azrael Seoeun added a comment -

          Address comments and rebase on the latest commit.

          Show
          seoeun25 Azrael Seoeun added a comment - Address comments and rebase on the latest commit.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . -1 the patch contains 1 line(s) longer than 132 characters
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 1 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1665
          . Tests failed: 3
          . Tests errors: 0

          . The patch failed the following testcases:

          . testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService)
          . testActionKillCommandActionNumbers(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
          . testValid(org.apache.oozie.cli.TestValidation)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2326/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . -1 the patch contains 1 line(s) longer than 132 characters . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 1 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1665 . Tests failed: 3 . Tests errors: 0 . The patch failed the following testcases: . testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService) . testActionKillCommandActionNumbers(org.apache.oozie.command.coord.TestCoordActionsKillXCommand) . testValid(org.apache.oozie.cli.TestValidation) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2326/
          Hide
          seoeun25 Azrael Seoeun added a comment -

          Fix . -1 the patch contains 1 line(s) longer than 132 characters.
          Test failures are unrelated.

          Show
          seoeun25 Azrael Seoeun added a comment - Fix . -1 the patch contains 1 line(s) longer than 132 characters. Test failures are unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . +1 the patch does adds/modifies 2 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 1 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1665
          . Tests failed: 3
          . Tests errors: 0

          . The patch failed the following testcases:

          . testValid(org.apache.oozie.cli.TestValidation)
          . testSubmitDoAs(org.apache.oozie.client.TestOozieCLI)
          . testBundleRerunInPausedWithError(org.apache.oozie.command.bundle.TestBundleRerunXCommand)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2328/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 2 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 1 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1665 . Tests failed: 3 . Tests errors: 0 . The patch failed the following testcases: . testValid(org.apache.oozie.cli.TestValidation) . testSubmitDoAs(org.apache.oozie.client.TestOozieCLI) . testBundleRerunInPausedWithError(org.apache.oozie.command.bundle.TestBundleRerunXCommand) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2328/
          Hide
          seoeun25 Azrael Seoeun added a comment -

          My bad, fix the TestValidation.

          Show
          seoeun25 Azrael Seoeun added a comment - My bad, fix the TestValidation.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 1 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1665
          . Tests failed: 1
          . Tests errors: 0

          . The patch failed the following testcases:

          . testValid(org.apache.oozie.cli.TestValidation)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2329/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 1 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1665 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testValid(org.apache.oozie.cli.TestValidation) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2329/
          Hide
          seoeun25 Azrael Seoeun added a comment -

          Fix TestValidation failure.

          Show
          seoeun25 Azrael Seoeun added a comment - Fix TestValidation failure.
          Hide
          hadoopqa Hadoop QA added a comment -

          Testing JIRA OOZIE-2159

          Cleaning local git workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          +1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . +1 the patch does adds/modifies 3 testcase(s)
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          -1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . -1 the patch seems to introduce 2 new javac warning(s)
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1665
          . Tests failed: 1
          . Tests errors: 1

          . The patch failed the following testcases:

          . testGetList(org.apache.oozie.executor.jpa.TestCoordJobQueryExecutor)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/2334/

          Show
          hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2159 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . +1 patch compiles . -1 the patch seems to introduce 2 new javac warning(s) +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1665 . Tests failed: 1 . Tests errors: 1 . The patch failed the following testcases: . testGetList(org.apache.oozie.executor.jpa.TestCoordJobQueryExecutor) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2334/
          Hide
          rkanter Robert Kanter added a comment -

          LGTM. Can you double-check the javac warnings and test failure that Jenkins reported?

          Show
          rkanter Robert Kanter added a comment - LGTM. Can you double-check the javac warnings and test failure that Jenkins reported?
          Hide
          seoeun25 Azrael Seoeun added a comment -

          Sure.
          Sorry for messy stuff, my local environment setting make to pass the test case.

          Javac warning due to deprecated annotation.
          The test failure is unrelated.

          Show
          seoeun25 Azrael Seoeun added a comment - Sure. Sorry for messy stuff, my local environment setting make to pass the test case. Javac warning due to deprecated annotation. The test failure is unrelated.
          Hide
          rkanter Robert Kanter added a comment -

          Sorry for taking so long to follow up on this. I had said "Ship It!" on RB but never actually committed it or +1'd here.

          +1
          Thanks Azrael. Committed to trunk!

          Show
          rkanter Robert Kanter added a comment - Sorry for taking so long to follow up on this. I had said "Ship It!" on RB but never actually committed it or +1'd here. +1 Thanks Azrael. Committed to trunk!
          Hide
          Dongying Jiao Dongying Jiao added a comment -

          Hi:
          Not sure if it is proper to post here.
          I backport this JIRA in oozie 4.2.0 release, but has several UT failures in TestV2ValidateServlet.
          From UT output of TestV2ValidateServlet#testValidateBundle:
          error[E0701], E0701: XML schema error, bundle.xml, org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 115; cvc-elt.1: Cannot find the declaration of element 'bundle-app'.
          org.apache.oozie.servlet.XServletException: E0701: XML schema error, bundle.xml, org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 115; cvc-elt.1: Cannot find the declaration of element 'bundle-app'.

          If I modify validate(String xml) function in V2ValidateServlet.java from :
          if (!e.getMessage().contains("cvc-elt.1.a")) {
          exception = e;
          break;
          }
          to:
          if (!e.getMessage().contains("cvc-elt.1"))

          { exception = e; break; }

          Then this UT can pass.
          I wonder what is the difference between exception message "cvc-elt.1" and "cvc-elt.1.a".
          Why "cvc-elt.1" is generated from my environment instead of "cvc-elt.1.a"?
          Thanks very much.

          Show
          Dongying Jiao Dongying Jiao added a comment - Hi: Not sure if it is proper to post here. I backport this JIRA in oozie 4.2.0 release, but has several UT failures in TestV2ValidateServlet. From UT output of TestV2ValidateServlet#testValidateBundle: error [E0701] , E0701: XML schema error, bundle.xml, org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 115; cvc-elt.1: Cannot find the declaration of element 'bundle-app'. org.apache.oozie.servlet.XServletException: E0701: XML schema error, bundle.xml, org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 115; cvc-elt.1: Cannot find the declaration of element 'bundle-app'. If I modify validate(String xml) function in V2ValidateServlet.java from : if (!e.getMessage().contains("cvc-elt.1.a")) { exception = e; break; } to: if (!e.getMessage().contains("cvc-elt.1")) { exception = e; break; } Then this UT can pass. I wonder what is the difference between exception message "cvc-elt.1" and "cvc-elt.1.a". Why "cvc-elt.1" is generated from my environment instead of "cvc-elt.1.a"? Thanks very much.
          Hide
          andras.piros Andras Piros added a comment -

          HI Dongying Jiao can you please open a subsequent JIRA for backporting to 4.2.0 and post your patch on ReviewBoard or attach to the JIRA?

          Thanks!

          Show
          andras.piros Andras Piros added a comment - HI Dongying Jiao can you please open a subsequent JIRA for backporting to 4.2.0 and post your patch on ReviewBoard or attach to the JIRA? Thanks!
          Hide
          Dongying Jiao Dongying Jiao added a comment -

          Hi Andras:
          I created OOZIE-2746 to track this issue.
          Thanks very much.

          Show
          Dongying Jiao Dongying Jiao added a comment - Hi Andras: I created OOZIE-2746 to track this issue. Thanks very much.
          Hide
          rkanter Robert Kanter added a comment -

          Closing issue; Oozie 4.3.0 is released.

          Show
          rkanter Robert Kanter added a comment - Closing issue; Oozie 4.3.0 is released.

            People

            • Assignee:
              seoeun25 Azrael Seoeun
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development