[OODT-951] Wrong null checker

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.9
• Component/s: workflow manager
• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Chris A. Mattmann
• Reporter: JC
• Created: 21/Jun/17 15:29
• Updated: 26/Feb/18 02:29
• Resolved: 26/Feb/18 02:29

Description

Hi

In a recent Github snapshot, I've found a following code smell.

Path: workflow/src/main/java/org/apache/oodt/cas/workflow/engine/PrioritizedQueueBasedWorkflowEngine.java

69   public PrioritizedQueueBasedWorkflowEngine(WorkflowInstanceRepository repo    ,
70       PrioritySorter prioritizer, WorkflowLifecycleManager lifecycle,
71       EngineRunner runner, WorkflowRepository modelRepo, long querierWaitSec    onds) {
72     this.repo = repo;
73     this.prioritizer = prioritizer != null ? new HighestFIFOPrioritySorter(1    ,
74         50, 1) : prioritizer;
75     this.lifecycle = lifecycle;
76     this.modelRepo = modelRepo;

In Line 73, prioritizer != null should be prioritizer == null? This might be a trivial issue but wanted to report just in case.

Thanks!