[OODT-950] Condition that compares the same expression

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.9
• Component/s: push pull framework
• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Chris A. Mattmann
• Reporter: JC
• Created: 18/Apr/17 20:49
• Updated: 26/Feb/18 02:29
• Resolved: 26/Feb/18 02:29

Description

Hi

In a recent Github mirror, I've found the following suspicious code in pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java

662     Protocol modifyAvailableSessionForPath(RemoteSiteFile file)
663             throws RemoteConnectionException {
664         Protocol session = getAvailableSession();
665         if (!file.getSite().getURL().getHost().equals(
666                 file.getSite().getURL().getHost())
667                 || !protocolHandler.isProtocolConnected(session)) {
668             protocolHandler.disconnect(session);
669             session = protocolHandler.getAppropriateProtocol(file, /* reuse */
670             false, /* navigate */true);
671         } else {

In Line 665 and 666, equals compares the same expression. This may not be an issue but wanted to report just in case. Thanks!