[OODT-79] LRUScheduler removes a job from the JobQueue, but adds it back if can't schedule it, which (in the JobStack impl) causes JobRepo to create duplicate copies of the same JobSpec with different JobIds

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.1-incubating
• Fix Version/s: 0.2
• Component/s: resource manager

Environment

none

• Assignee: Brian Foster
• Reporter: Brian Foster
• Created: 10/Dec/10 22:33
• Updated: 15/Dec/10 17:17
• Resolved: 15/Dec/10 17:17

Description

In LRUScheduler:

public void run()

{ .... exec = myJobQueue.getNextJob(); .... (on failure) myJobQueue.addJob(spec); }

In myJobQueue.getNextJob() (where myJobQueue is instanceof JobStack) the JobSpec is deleted and in myJobQueue.addJob(spec) repo.addJob(JobSpec) is called as shown:

public String addJob(JobSpec spec) throws JobQueueException

{ String jobId = safeAddJob(spec); .... }

private String safeAddJob(JobSpec spec)

{ .... return this.repo.addJob(spec); .... }

• Point being: JobStack's addJob(JobSpec) should not be called by LRUScheduler when adding a job back to the JobStack because the jobspec is already stored in JobRepository and everytime addJob(JobSpec) is called the JobSpec is given a new JobId

• Patch will introduce a new method to JobQueue called: requeueJob(JobSpec) which will add the JobSpec to the back of the JobQueue and update the JobRepo.