[OODT-734] Fix File Manager Unit Tests - 'system' Package

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: file manager
• Labels: patch test
• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Ross Laidlaw
• Reporter: Ross Laidlaw
• Created: 05/Aug/14 23:16
• Updated: 06/Aug/14 00:44
• Resolved: 06/Aug/14 00:44

Description

This step fixes unit tests for the file manager's 'system' package. Two classes were updated: TestXmlRpcFileManager and TestXmlRpcFileManagerClient.

For each class, hard-coded paths to test resources were replaced with paths from URLs via the 'getResource()' method. Additionally, java.util.Properties objects were used to set System properties and then restore initial settings after each test method runs (in setUp and tearDown methods).

The following Maven command was used to run each test class from the top-level (trunk) directory:

mvn clean -Dtest=<test class name> -DfailIfNoTests=false test -pl filemgr -am

Before:

TestXmlRpcFileManager Results :
  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

TestXmlRpcFileManagerClient Results :
  Tests run: 4, Failures: 4, Errors: 0, Skipped: 0

After:

TestXmlRpcFileManager Results :
  Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

TestXmlRpcFileManagerClient Results :
  Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

5 tests were fixed in total.