[OODT-686] AddProductTypeCliAction should prompt for ProductTypeId

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.10
• Component/s: file manager

Environment

0.7-SNAPSHOT

• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Chris A. Mattmann
• Reporter: Rishi Verma
• Created: 07/May/14 21:38
• Updated: 30/Aug/15 05:06
• Resolved: 30/Aug/15 01:33

Description

Currently, the AddProductTypeCliAction [1] breaks (returns NullPointerException) when generating a new product type even when all required valid arguments are supplied.

Reproducible steps:
1. Navigate to filemgr/bin
2. Issue: ./filemgr-client -op -addPT -typeName TestProductType1 -repository "file:///usr/local/oodt/data/archive" -typeDesc "This is a test product type" -versionClass "gov.nasa.jpl.oodt.myproductversioner" -url http://localhost:9000
3. View failure message: "ERROR: Failed to add product type with name 'TestProductType1', description 'This is a test product type', repository 'file:///usr/local/oodt/data/archive, and versioner 'gov.nasa.jpl.oodt.myproductversioner' : null"

After some investigation, I found that the underlying problem here is that the AddProductTypeCliAction does not generate a ProductType object that has a ProductTypeId field set. I'm not sure why AddProductTypeCliAction does not prompt the user for this like it does for other arguments, because the XmlRepositoryManager requires a ProductTypeId to be present in order for policy to be generated (see [2] addProductType method). If ProductTypeId is not present within the ProductType object generated by this CliAction, then the XmlRepositoryManager will issue an error. In fact, I'll bet future repository managers will need ProductTypeId as much as XmlRepositoryManager does, so fixing this CliAction will be beneficial.

–
[1] http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/AddProductTypeCliAction.java
[2] http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/repository/XMLRepositoryManager.java

Issue Links

• relates to: OODT-690 RADiX example policy for GenericFile missing "<metadata/>" node

Sub-Tasks

• XmlStructFactory generates invalid ProductType if policy is missing "<metadata/>" or "<metExtractors/>": Resolved