[OODT-659] CommonsNetFtpProtocol.ls() method is causing unnecessary traffic

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.7
• Component/s: push pull framework

Environment

*nix

• Skill Level: Committer (Medium) - This is for regular contributors/committers
• Assignee: Cameron Goodale
• Reporter: Cameron Goodale
• Due: 08/Nov/13
• Created: 08/Nov/13 22:15
• Updated: 08/Nov/13 22:18
• Resolved: 08/Nov/13 22:18

Description

While trying to download files from an FTP server with 6400+ files on it pushpull would crash with a 421 Error from the FTP server.

After a lot of research and testing we found that the code was calling pwd() for each file when building up the list within the ls() method.

In the case of trying to scan a directory with a large number of files, this can make the FTP server drop the connection due to the large number of request.

We moved the call to pwd outside of the loop, and everything works great. We are able to download the files easily now.