[OODT-649] Add PathUtils.replaceEnvVariables() wrapper around retrieved context parameters

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: product server
• Labels: gsoc
• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Ross Laidlaw
• Reporter: Ross Laidlaw
• Created: 27/Jul/13 18:46
• Updated: 08/Aug/13 18:22
• Resolved: 27/Jul/13 18:53

Description

Methods in several classes in the cas.product.service.resources package retrieve parameters from the servlet context using the context.getInitParameter(String parameterName) method call, for example as follows:

setWorkingDirPath(context.getInitParameter("filemgr.working.dir"));

But these parameters may contain environment variables such as [HOME] or [FMPROD_HOME], etc. Currently, these aren't processed properly and the getInitParameter call needs to be wrapped in a call to PathUtils.replaceEnvVariables() (from the cas-metadata module) to process the environment variables, for example as follows:

setWorkingDirPath(PathUtils.replaceEnvVariables(
  context.getInitParameter("filemgr.working.dir")));

This is already done in the original Data, RDF and RSS servlets but was accidentally omitted from the new resource classes in the cas.product.service.resources package.