[OODT-573] Suggested refactoring for return statement in getTopNProducts method in LuceneCatalog class

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.6
• Component/s: file manager
• Assignee: Ross Laidlaw
• Reporter: Ross Laidlaw
• Created: 11/Mar/13 02:21
• Updated: 08/Jun/13 00:10
• Resolved: 08/Jun/13 00:10

Description

The getTopNProducts method in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog currently has the following return statement:

LuceneCatalog.java

public List<Product> getTopNProducts(int n, ProductType type) throws CatalogException
{
  ...
  if (products != null) {
    return products;
        } else
            return null;
}

I believe that we can replace the above statement with the following:

LuceneCatalog.java

public List<Product> getTopNProducts(int n, ProductType type) throws CatalogException
{
  ...
  return products;
}