Uploaded image for project: 'OODT'
  1. OODT
  2. OODT-553

Update org.apache.oodt.commons.exec.EnvUtilities to Use System.getEnvironment

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6
    • Component/s: commons
    • Labels:
      None

      Description

      The environment variables utilities use a command line invocation of 'env' to get the environment variables due to the fact that java 1.4 did not have a System.getEnvironment call.

      This is no longer the best solution (and is suspected of causing some errors).

        Activity

        Hide
        mstarch Michael Starch added a comment -

        This is a proposed patch.

        It uses System.getEnvironment() (instead of exec "env"). The test cases (additional) will only run on UNIX systems because they require USER and HOME environment variables to be set.

        Could another user review it? I am new.

        Enjoy!

        Show
        mstarch Michael Starch added a comment - This is a proposed patch. It uses System.getEnvironment() (instead of exec "env"). The test cases (additional) will only run on UNIX systems because they require USER and HOME environment variables to be set. Could another user review it? I am new. Enjoy!
        Hide
        chris.a.mattmann@jpl.nasa.gov Mattmann, Chris A (388J) added a comment -

        Thanks Mike feel free to use http://reviews.apache.org and the Review Board instance too if you like

        Sent from my iPhone

        Show
        chris.a.mattmann@jpl.nasa.gov Mattmann, Chris A (388J) added a comment - Thanks Mike feel free to use http://reviews.apache.org and the Review Board instance too if you like Sent from my iPhone
        Hide
        chrismattmann Chris A. Mattmann added a comment -
        • patch applied in r1441830, thanks Mike!
        Show
        chrismattmann Chris A. Mattmann added a comment - patch applied in r1441830, thanks Mike!
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        Mike feel free to mark this as submitted in Review Board now since I committed your patch.

        Show
        chrismattmann Chris A. Mattmann added a comment - Mike feel free to mark this as submitted in Review Board now since I committed your patch.

          People

          • Assignee:
            chrismattmann Chris A. Mattmann
            Reporter:
            mstarch Michael Starch
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development