Uploaded image for project: 'OODT'
  1. OODT
  2. OODT-243

Add method is called on already existing jobspec

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.1-incubating, 0.2
    • Fix Version/s: 0.3
    • Component/s: resource manager
    • Labels:
      None
    • Environment:

      JPL internal JIRA

      Description

      LRUScheduler removes job, then adds it back if can't schedule which causes problem with Job Repo.

      In LRUScheduler:

      public void run() { .... exec = myJobQueue.getNextJob(); .... (on failure) myJobQueue.addJob(spec); }
      

      In myJobQueue.getNextJob() (where myJobQueue is instanceof JobStack) the JobSpec is deleted and in addJob repo.addJob(JobSpec) is called as shown:

      public String addJob(JobSpec spec) throws JobQueueException { String jobId = safeAddJob(spec); .... }
      private String safeAddJob(JobSpec spec) { .... return this.repo.addJob(spec); .... }
      

      Point being: JobRepository should either do away with updateJob(JobSpec) method since in current implementation addJob(JobSpec) must support update to work properly, or replace getNextJob() with two different methods: peek() and delete(JobSpec)

        Attachments

          Activity

            People

            • Assignee:
              chrismattmann Chris A. Mattmann
              Reporter:
              bfoster Brian Foster
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: