[OODT-243] Add method is called on already existing jobspec

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1-incubating, 0.2
• Fix Version/s: 0.3
• Component/s: resource manager

Environment

JPL internal JIRA

• Assignee: Chris A. Mattmann
• Reporter: Brian Foster
• Created: 19/Jun/11 05:26
• Updated: 19/Jun/11 05:30
• Resolved: 19/Jun/11 05:30

Description

LRUScheduler removes job, then adds it back if can't schedule which causes problem with Job Repo.

In LRUScheduler:

public void run() { .... exec = myJobQueue.getNextJob(); .... (on failure) myJobQueue.addJob(spec); }

In myJobQueue.getNextJob() (where myJobQueue is instanceof JobStack) the JobSpec is deleted and in addJob repo.addJob(JobSpec) is called as shown:

public String addJob(JobSpec spec) throws JobQueueException { String jobId = safeAddJob(spec); .... }
private String safeAddJob(JobSpec spec) { .... return this.repo.addJob(spec); .... }

Point being: JobRepository should either do away with updateJob(JobSpec) method since in current implementation addJob(JobSpec) must support update to work properly, or replace getNextJob() with two different methods: peek() and delete(JobSpec)