Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: validation-1.0.0
    • Fix Version/s: validation-1.0.0
    • Component/s: validation
    • Labels:
      None

      Description

      ValidateMethodInterceptor should not be part of public API so make it package private.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7m 48s 1 Mikhail Mazurskiy 10/Feb/13 10:36
        Resolved Resolved Closed Closed
        377d 2h 33m 1 Mikhail Mazurskiy 22/Feb/14 13:09
        Mikhail Mazurskiy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Onami-Validation #14 (See https://builds.apache.org/job/Onami-Validation/14/)
        ONAMI-80 Make interceptor package private and remove setter because it'll never be used (Revision 1444524)

        Result = FAILURE
        ash2k :
        Files :

        • /incubator/onami/sandbox/validation/src/main/java/org/apache/onami/validation/ValidateMethodInterceptor.java
        Show
        Hudson added a comment - Integrated in Onami-Validation #14 (See https://builds.apache.org/job/Onami-Validation/14/ ) ONAMI-80 Make interceptor package private and remove setter because it'll never be used (Revision 1444524) Result = FAILURE ash2k : Files : /incubator/onami/sandbox/validation/src/main/java/org/apache/onami/validation/ValidateMethodInterceptor.java
        Mikhail Mazurskiy made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s validation-1.0.0 [ 12324016 ]
        Resolution Fixed [ 1 ]
        Hide
        Mikhail Mazurskiy added a comment -

        Fixed in 1444524

        Show
        Mikhail Mazurskiy added a comment - Fixed in 1444524
        Hide
        Mikhail Mazurskiy added a comment -

        Also, setter method setValidatorFactory() is useless because it's not used and is out of reach in case ValidateMethodInterceptor class is not public. So it can be removed too.

        Show
        Mikhail Mazurskiy added a comment - Also, setter method setValidatorFactory() is useless because it's not used and is out of reach in case ValidateMethodInterceptor class is not public. So it can be removed too.
        Mikhail Mazurskiy created issue -

          People

          • Assignee:
            Mikhail Mazurskiy
            Reporter:
            Mikhail Mazurskiy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development