[OMID-87] Fix BatchPool initialization - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Critical
Resolution: Fixed
Affects Version/s: 0.8.2.0
Fix Version/s: 0.9.0.0
Labels:
- batch
- batchpool
- creation
- fix

Description

When initializing the ObjectPool for Batch java objects in BatchPoolModule.java, an Apache's GenericObjectPool is used. The pool configuration lacks the call to config.setMaxIdle(int), which provokes that when the Batch objects are returned to the ObjectPool during the pre-creation phase, those above the default max idle number of objects in the pool (which is 8 according to the Apache documentation) are destroyed.

If at some point the TSO needs to access those Batch objects between 8 and the number specified in the Omid configuration (numConcurrentCTWriters), they will be created on the fly, which it was we want to avoid when pre-creating the ObjectPool during the TSO initialization.