Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • None

    Description

      Once OMID-107 is committed (which replaced all deprecated methods), the only things I've identified that need to change are:

      • Instantiation of¬†CellComparator should be done through HBaseShims since it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was changed to an interface. Another alternative would be to write our own CellComparator.
        public static SortedMap<Cell, Optional<Cell>> mapCellsToShadowCells(List<Cell> cells) {
        
        // Move CellComparator to HBaseSims for 2.0 support
        // Need to access through CellComparatorImpl.COMPARATOR
        SortedMap<Cell, Optional<Cell>> cellToShadowCellMap
        = new TreeMap<Cell, Optional<Cell>>(new CellComparator());

        The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of instantiating a CellComparator.

      • Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase 2.0 uses TableDescriptor and TableDescriptorBuilder. chrajeshbabu32@gmail.com and ankit@apache.org - do you know why existing admin.createTable(HTableDescriptor) wouldn't work?¬†HTableDescriptor implements TableDescriptor.

      Attachments

        1. 0001-omid-110.patch
          57 kB
          Yoni Gottesman
        2. OMID-110_wip1.patch
          8 kB
          James R. Taylor
        3. omid110.patch
          74 kB
          Yoni Gottesman
        4. omid110-last_bug_fix.patch
          1 kB
          Yoni Gottesman

        Activity

          People

            yonigo Yoni Gottesman
            jamestaylor James R. Taylor
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: