[OLTU-191] Get resource fails with NPE

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: oauth2-1.0.2
• Component/s: demo-client, oauth2-client
• Assignee: Stein Welberg
• Reporter: Jasha Joachimsthal
• Created: 29/Feb/16 20:26
• Updated: 02/Mar/16 13:26
• Resolved: 01/Mar/16 01:05

Description

A resource call in the client demo fails with an NPE on the validator.

2016-02-29 21:17:30.066:WARN::/get_resource
java.lang.NullPointerException
	at org.apache.oltu.oauth2.client.response.OAuthClientResponse.validate(OAuthClientResponse.java:80)
	at org.apache.oltu.oauth2.client.response.OAuthClientResponse.init(OAuthClientResponse.java:71)
	at org.apache.oltu.oauth2.client.response.OAuthClientResponseFactory.createCustomResponse(OAuthClientResponseFactory.java:63)
	at org.apache.oltu.oauth2.client.URLConnectionClient.execute(URLConnectionClient.java:115)
	at org.apache.oltu.oauth2.client.OAuthClient.resource(OAuthClient.java:81)
	at org.apache.oltu.oauth2.client.demo.controller.ResourceController.authorize(ResourceController.java:57)
	...

To reproduce:

1. start the demo client
2. do the authorize flow for Facebook
3. do a resource call for https://graph.facebook.com/me

The HTTP request towards Facebook succeeds, but it response cannot be converted into an OAuthResourceResponse.

The client demo uses the URLConnectionClient implementation for HttpClient.

Issue Links

• is broken by: OLTU-185 OAuthClientResponse lack headers access to be used for correct RESTful client implementation