[OLIO-15] SQL to count friends in friends.php overly complex

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: php-app
• Assignee: Akara Sucharitakul
• Reporter: Nick Lanham
• Created: 21/Nov/08 20:34
• Updated: 28/Jan/09 20:47
• Resolved: 14/Jan/09 05:00

Description

In public_html/friends.php:60 there's the following query:

$query = "select count as count from PERSON as p, PERSON_PERSON as pp where pp.person_username='$user' and p.username=pp.friends_username and pp.is_accepted=1";

This simply counts the # of friends you have and could just as well be written as:

$query = "select count as count from PERSON_PERSON as pp where pp.person_username='$user' and pp.is_accepted=1";

The only difference here would be if a person got deleted from the PERSON table but not from the PERSON_PERSON table which should never happen.