Uploaded image for project: 'Olingo'
  1. Olingo
  2. OLINGO-453

BatchWriter invalid serialisation of get requests

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • V2 2.0.0
    • V2 2.0.1
    • odata2-core

    Description

      While refactoring the batch parser I mentioned a bug in the BatchRequestWriter implementation.

      In test case testBatchWithGetAndPost the following request is being created

      --batch_123
      Content-Type: application/http
      Content-Transfer-Encoding: binary
      Content-Id: 000

      GET Employees HTTP/1.1
      Accept: application/json //<- Missing 2xCRLF
      --batch_123
      // next body part
      // .....

      Due to the OData specification the CRLF before a boundary belongs logically to the boundary itself. In addition a mandatory CRLF after the header block must be present.

      Attachments

        1. batchWriterBugfix.diff
          12 kB
          Christian Holzer

        Activity

          People

            chrisam Christian Amend
            cholzer Christian Holzer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: