[OLINGO-249] 'formatLiteral' function escapes only the first occurrence of a single quote instead of all of them

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: V2 1.1.0, V2 1.2.0
• Component/s: odata4-client-JS
• Environment: All
• Assignee: Bing Li
• Reporter: Daniel Molina
• Created: 22/Apr/14 17:43
• Updated: 11/Mar/15 09:39
• Resolved: 16/May/14 02:57

Description

Handling of single quotes (‘) in the “formatLiteral” function (line 6879 in datajs-1.1.2.js) is broken if 'value' contains more than one occurrence. The relevant code is:

var formatLiteral = function (value, type) {
…
value = encodeURIComponent(value.replace("'", "''"));

The problem is that value.replace("'", "''") replaces only the first occurrence of ', not all of them which is the intended behavior. The code should be:

value = encodeURIComponent(value.replace(/'/g, "''"));