[OLINGO-1568] Error serializing BigDecimal when passed certain BigDecimal values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: (Java) V4 4.8.0, (Java) V4 4.9.0
• Fix Version/s: (Java) V4 4.10.0
• Component/s: odata4-client
• Assignee: mibo
• Reporter: Victor Hu
• Created: 05/May/22 23:07
• Updated: 24/Sep/23 05:54
• Resolved: 24/Sep/23 05:54

Description

This is a refiling OLINGO-1549 except categorized as a bug.

This bug was introduced with the change made in OLINGO-1480 to allow for larger precision/scale values when passed in as a BigDecimal as they can exceed the default precision of 40 and scale of 25.

However, this broke insertions for values ranging from ]0.0, 0.1[ as their BigDecimal representations have precision less than scale (which is not allowed according to the OData CSDL).

This also breaks insertions for BigDecimal values that do not specify precision - an arbitrary precision in BigDecimal is represented as 0 versus the arbitrary precision representation of null in OData.

The following throws an exception due to this bug

new ClientObjectFactoryImpl().newPrimitiveValueBuilder().buildDecimal(new BigDecimal("0.04")).toString();

java.lang.IllegalArgumentException: org.apache.olingo.commons.api.edm.EdmPrimitiveTypeException: The value '0.04' does not match the facets' constraints.

 

Issue Links

• relates to: OLINGO-1549 cannot create amount smaller than 0.10