[OLINGO-1357] Construction of EdmTypeKind very expensive

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: (Java) V4 4.6.0
• Fix Version/s: (Java) V4 4.7.0
• Component/s: odata4-commons
• Assignee: mibo
• Reporter: Dirk Mahler
• Created: 13/May/19 12:12
• Updated: 30/May/24 19:41
• Resolved: 14/May/19 19:11

Description

From the attached screenshot of the VisualVM sampler can be seen that construction of EdmTypeInfo instances is very expensive as EdmPrimitiveTypeKind.valueOf is used:

    try {
      primitiveType = EdmPrimitiveTypeKind.valueOf(typeName);
    } catch (final IllegalArgumentException e) {
      primitiveType = null;
    }

The problem here is the exception that is thrown if the value cannot be found. Suggesting to use a static Map to cache values, PR will be provided.

Issue Links

• relates to: OLINGO-1624 Serialization performance regression in Olingo 5
• links to: GitHub Pull Request #51