[OLINGO-1330] SingletonPrimitiveType#getName() is expensive

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: (Java) V4 4.5.0
• Fix Version/s: (Java) V4 4.7.0
• Component/s: odata4-commons
• Assignee: mibo
• Reporter: Dirk Mahler
• Created: 16/Jan/19 09:39
• Updated: 10/May/19 16:00
• Resolved: 10/May/19 16:00

Description

The implementation of SingletonPrimitiveType#getName() is expensive if monitored in the JVisualVM sampler:
 

  @Override
  public String getName() {
    return getClass().getSimpleName().substring(3);
  }

The main problem here is the Class#getSimpleName is a quite "complex" calculation that's exectued every time when the method is invoked. The name should be cached instead.