[OLINGO-1219] When nullable key is defined Encoder would throw NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: V2 2.0.9
• Fix Version/s: V2 2.0.12
• Component/s: odata2-core
• Assignee: mibo
• Reporter: Song Yihan
• Created: 03/Jan/18 07:28
• Updated: 12/Mar/22 10:58
• Resolved: 12/Mar/22 10:58

Description

in current Encoder implementation, if given input is null, an NPE would be thrown

The scenario would be, consider an Entity which key is allowed to be null in Edmx, thus, the data retrieved in data source would be a HashMap only with non-null value, when createEntryKey<-createSelfLink, we generate the key representation from the given data, some of the key would be null and passed to Encoder, which would throw NullPointerException and skip the check of its corresponding facets

if (value == null) {
if (facets == null || facets.isNullable() == null || facets.isNullable())

{ return null; }

else

{ throw new EdmSimpleTypeException(EdmSimpleTypeException.VALUE_NULL_NOT_ALLOWED); }

}

A pull request has been created aim to fix it at https://github.com/apache/olingo-odata2/pull/14