[OGNL-56] the NOT of complex expression fails

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.7
• Component/s: ExpressionCompiler
• Assignee: Jesse Kuhnert
• Reporter: Alexander Gavrilov
• Created: 25/Apr/07 04:39
• Updated: 28/Apr/07 13:55
• Resolved: 28/Apr/07 13:55

Description

The test case

{ "!(true && true)", Boolean.FALSE}

,

for org.ognl.test.ArithmeticAndLogicalOperatorsTest fails. This is because of the expression !(condition1() && condition2()) is compiled to form

!ognl.OgnlOps.booleanValue((($SomeClass_490)$2).condition1()) ? ($w) ((($SomeClass_490)$2).condition2()) : ($w) ((($SomeClass_490)$2).condition2());"

where the negation is applied to ognl.OgnlOps.booleanValue(..) but not to the full expression result.

this bug has workaround to use !true || !true instead, but it require the revision of a lot code amount.